You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/13 06:13:38 UTC
[PR] test(group): pin the create-group request and its VO mapping [rocketmq-dashboard]
zjncs opened a new pull request, #6577:
URL: https://github.com/apache/rocketmq-dashboard/pull/6577
### What
CreateConsumerGroupDTO is the create-group request, and its toConsumerGroupVO() is the bridge the create flow and the group import both walk. It had no test. This pins: the name is required, the retry/delay knobs must not go negative, the mapping carries every field across, and absent retry/delay values keep the group's own defaults instead of blowing up on unboxing.
### Verification
- New tests on unmodified code: **4/4 green**, checkstyle clean.
- Discriminating mutation: the null guards removed from the retry/delay copy (red - NullPointerException on the null path is caught).
- Restored: green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(group): pin the create-group request and its VO mapping [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #6577: test(group): pin the create-group request and its VO mapping
URL: https://github.com/apache/rocketmq-dashboard/pull/6577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(group): pin the create-group request and its VO mapping [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #6577:
URL: https://github.com/apache/rocketmq-dashboard/pull/6577#issuecomment-6565990810
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org