You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/17 09:57:33 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #14370: [feature-wip](planner) Update cache when analysis job finished
Kikyou1997 opened a new pull request, #14370:
URL: https://github.com/apache/doris/pull/14370
# Proposed changes
Issue Number: noissue
## Problem summary
1. Update cache when analysis job finished
2. Rename `StatisticsStorageInitializer` to `InernalSchemaInitializer`
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #14370: [feature-wip](planner) Update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #14370:
URL: https://github.com/apache/doris/pull/14370#discussion_r1027451993
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/InternalSchemaInitializer.java:
##########
@@ -46,20 +44,26 @@
import java.util.List;
import java.util.Map;
-public class StatisticStorageInitializer extends Thread {
+public class InternalSchemaInitializer extends Thread {
- private static final Logger LOG = LogManager.getLogger(StatisticStorageInitializer.class);
+ private static final Logger LOG = LogManager.getLogger(InternalSchemaInitializer.class);
public static boolean forTest = false;
+ /**
+ * If internal table creation failed, will retry after below seconds.
+ */
+ public static final int TABLE_CREATION_RETRY_INTERVAL_IN_SECONDS = 5;
+
+
public void run() {
- if (forTest) {
+ if (forTest || (!Env.getCurrentEnv().isMaster() && Env.getCurrentEnv().isReady())) {
Review Comment:
> `forTest` means for ut or regression？
ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #14370: [feature-wip](planner) Update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #14370:
URL: https://github.com/apache/doris/pull/14370#discussion_r1027450102
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java:
##########
@@ -110,6 +110,8 @@ public static ColumnStatistic fromResultRow(ResultRow resultRow) {
columnStatisticBuilder.setNumNulls(Double.parseDouble(resultRow.getColumnValue("null_count")));
columnStatisticBuilder.setDataSize(Double
.parseDouble(resultRow.getColumnValue("data_size_in_bytes")));
+ columnStatisticBuilder.setAvgSizeByte(columnStatisticBuilder.getDataSize()
Review Comment:
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14370: [feature-wip](planner) Update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14370:
URL: https://github.com/apache/doris/pull/14370#issuecomment-1318597207
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.16 seconds
load time: 442 seconds
storage size: 17150854212 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221117125724_clickbench_pr_48004.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #14370: [feature-wip](statistics) update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #14370:
URL: https://github.com/apache/doris/pull/14370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14370: [feature-wip](statistics) update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14370:
URL: https://github.com/apache/doris/pull/14370#issuecomment-1321551193
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #14370: [feature-wip](planner) Update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #14370:
URL: https://github.com/apache/doris/pull/14370#discussion_r1027311388
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/InternalSchemaInitializer.java:
##########
@@ -46,20 +44,26 @@
import java.util.List;
import java.util.Map;
-public class StatisticStorageInitializer extends Thread {
+public class InternalSchemaInitializer extends Thread {
- private static final Logger LOG = LogManager.getLogger(StatisticStorageInitializer.class);
+ private static final Logger LOG = LogManager.getLogger(InternalSchemaInitializer.class);
public static boolean forTest = false;
+ /**
+ * If internal table creation failed, will retry after below seconds.
+ */
+ public static final int TABLE_CREATION_RETRY_INTERVAL_IN_SECONDS = 5;
+
+
public void run() {
- if (forTest) {
+ if (forTest || (!Env.getCurrentEnv().isMaster() && Env.getCurrentEnv().isReady())) {
Review Comment:
`forTest` means for ut or regression？
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java:
##########
@@ -110,6 +110,8 @@ public static ColumnStatistic fromResultRow(ResultRow resultRow) {
columnStatisticBuilder.setNumNulls(Double.parseDouble(resultRow.getColumnValue("null_count")));
columnStatisticBuilder.setDataSize(Double
.parseDouble(resultRow.getColumnValue("data_size_in_bytes")));
+ columnStatisticBuilder.setAvgSizeByte(columnStatisticBuilder.getDataSize()
Review Comment:
if there are some rows to be deleted or rows need to be merged, the AvgSizeByte may becomes larger, is that right?
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/InternalSchemaInitializer.java:
##########
@@ -46,20 +44,26 @@
import java.util.List;
import java.util.Map;
-public class StatisticStorageInitializer extends Thread {
+public class InternalSchemaInitializer extends Thread {
- private static final Logger LOG = LogManager.getLogger(StatisticStorageInitializer.class);
+ private static final Logger LOG = LogManager.getLogger(InternalSchemaInitializer.class);
public static boolean forTest = false;
+ /**
+ * If internal table creation failed, will retry after below seconds.
+ */
+ public static final int TABLE_CREATION_RETRY_INTERVAL_IN_SECONDS = 5;
+
+
public void run() {
- if (forTest) {
+ if (forTest || (!Env.getCurrentEnv().isMaster() && Env.getCurrentEnv().isReady())) {
Review Comment:
how about if it is master, but its env is not ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14370: [feature-wip](statistics) update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14370:
URL: https://github.com/apache/doris/pull/14370#issuecomment-1321551220
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14370: [feature-wip](statistics) update cache when analysis job finished
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14370:
URL: https://github.com/apache/doris/pull/14370#issuecomment-1323684862
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org