[jira] [Comment Edited] (SENTRY-2109) Fix the logic of identifying HMS out of Sync

["kalyan kumar kalvagadda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302476#comment-16302476 ] 

kalyan kumar kalvagadda edited comment on SENTRY-2109 at 12/23/17 3:01 PM:
---------------------------------------------------------------------------

I have attached a patch to fix the issue and also added e2e tests around snapshot creation but there is still some work pending.
This new change is causing unit test failures as they are using mocking to test specific class. There is effort involved in fixing those tests. This patch comments them out for now.




was (Author: kkalyan):
I have attached a patch to fix the issue and also added e2e tests around snapshot creation but there is still some work pending.
This new change is causing unit test failures as they are using mocking to test specific class. There is effort involved in fixing those tests. This patch comments them out got now.



> Fix the logic of identifying HMS out of Sync
> --------------------------------------------
>
>                 Key: SENTRY-2109
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2109
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>             Fix For: 2.1.0
>
>         Attachments: SENTRY-2109.001.patch, Screenshot_HMS_NOTIFICATION_LOG.png
>
>
> Currently HMSFollower proactively checks if sentry is out of sync with HMS and initiates full snapshot, if needed.
> There will be false positives with the current logic if there are gaps in the event-id in the notification log sequence.
> This jira is aimed at making that logic robust.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)