You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Dmitry Gusev (JIRA)" <ji...@apache.org> on 2010/03/29 01:03:27 UTC
[jira] Created: (TAP5-1088) Bean editor model for
already contains a property model for property
Bean editor model for <class name> already contains a property model for property <property name>
-------------------------------------------------------------------------------------------------
Key: TAP5-1088
URL: https://issues.apache.org/jira/browse/TAP5-1088
Project: Tapestry 5
Issue Type: Test
Components: tapestry-core
Affects Versions: 5.2.0
Reporter: Dmitry Gusev
I'm getting exception in my app:
Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
Not sure if this is a bug or my misunderstanding of some T5 concepts.
Here is my use case:
I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
Here's my 'Item' class:
package org.apache.tapestry5.integration.app7.data;
public class Item {
private int id;
public Item(int id) {
this.id = id;
}
public int getId() {
return id;
}
public void setId(int id) {
this.id = id;
}
public String getDisplayName() {
return "Item #" + id;
}
}
and a part of beaneditor markup on Details page:
<t:beaneditor t:id="itemEditor" object="item" add="displayName"
submitLabel="Apply Edit">
You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1088:
---------------------------------------
I think the big problem here is that the behavior of parameters, in particular unbound parameters, changed with the other changes to the class transformation pipeline. I need to verify that and, if so, fix it (and any number of other potential bugs).
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1088:
---------------------------------------
I think the big problem here is that the behavior of parameters, in particular unbound parameters, changed with the other changes to the class transformation pipeline. I need to verify that and, if so, fix it (and any number of other potential bugs).
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: (was: 0001-Fix-for-TAP5-1088.patch)
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1088:
------------------------------------------
Assignee: Howard M. Lewis Ship
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-Fix-for-TAP5-1088.patch
Patch that fixes the issue.
Applying this fix make test I attached before to pass.
Also I checked other tests in tapestry-core project and they all passed too.
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Test
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Fix-for-TAP5-1088.patch, 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: (was: 0001-TestCase-illustrating-bug-with-bean-editor-model.patch)
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: (was: 0001-TestCase-illustrating-bug-with-bean-editor-model.patch)
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property when
combining model parameter with add parameter of BeanEditor or BeanEditForm
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1088:
---------------------------------------
Summary: Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm (was: Bean editor model for <class name> already contains a property model for property <property name>)
So much for my theory about parameters; I have verified with the debugger that they are working correctly.
However, that makes me wonder what's going on in your situation? It seems that the combination of the model parameter and the other parameters is what's toxic. However, the test case in the patch isn't for that scenario (its the default generate model, without explicitly binding the model parameter).
I think the correct solution here is that add, reorder, include, remove are applied ONLY if the model parameter is not bound. This applies to BeanEditor, BeanEditForm and Grid.
> Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Buck O' Five (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853108#action_12853108 ]
Buck O' Five commented on TAP5-1088:
------------------------------------
I hope your patch works as this bug has been preventing us from using t5.2 for months. I'm pretty surprised this has gone so long without being fixed. This bug has also been reported here TAP5-1051 and a small thread here: http://old.nabble.com/T5.2.0-SNAPHOT%3A-newbie-exceptions-submitting-form-with-BeanEditor-ts27947909.html#a27950914 .
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Buck O' Five (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853108#action_12853108 ]
Buck O' Five commented on TAP5-1088:
------------------------------------
I hope your patch works as this bug has been preventing us from using t5.2 for months. I'm pretty surprised this has gone so long without being fixed. This bug has also been reported here TAP5-1051 and a small thread here: http://old.nabble.com/T5.2.0-SNAPHOT%3A-newbie-exceptions-submitting-form-with-BeanEditor-ts27947909.html#a27950914 .
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1088) Bean editor model for
already contains a property model for property when
combining model parameter with add parameter of BeanEditor or BeanEditForm
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1088.
--------------------------------------
Fix Version/s: 5.2.0
Resolution: Fixed
> Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.0
>
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
Test case to reproduce the exception
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Test
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-Test-and-fix-for-TAP5-1088.patch
Unified diff for both test and the fix
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-Test-and-fix-for-TAP5-1088.diff
Test and fix in unified diff format
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TAP5-1088) Bean editor model for
already contains a property model for property
when combining model parameter with add parameter of BeanEditor or
BeanEditForm
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863550#action_12863550 ]
Howard M. Lewis Ship edited comment on TAP5-1088 at 5/3/10 6:42 PM:
--------------------------------------------------------------------
So much for my theory about parameters; I have verified with the debugger that they are working correctly.
However, that makes me wonder what's going on in your situation? It seems that the combination of the model parameter and the other parameters is what's toxic. However, the test case in the patch isn't for that scenario (its the default generate model, without explicitly binding the model parameter).
I think the correct solution here is that add, reorder, include, remove are applied ONLY if the model parameter is not bound. This applies to BeanEditor, BeanEditForm, BeanDisplay and Grid.
was (Author: hlship):
So much for my theory about parameters; I have verified with the debugger that they are working correctly.
However, that makes me wonder what's going on in your situation? It seems that the combination of the model parameter and the other parameters is what's toxic. However, the test case in the patch isn't for that scenario (its the default generate model, without explicitly binding the model parameter).
I think the correct solution here is that add, reorder, include, remove are applied ONLY if the model parameter is not bound. This applies to BeanEditor, BeanEditForm and Grid.
> Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-Fix-for-TAP5-1088.patch
Patch that fixes the issue.
Applying this fix make test I attached before to pass.
Also I checked other tests in tapestry-core project and they all passed too.
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Test
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Fix-for-TAP5-1088.patch, 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-Test-and-fix-for-TAP5-1088.patch
Unified diff for both test and the fix
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1088) Bean editor model for
already contains a property model for property when
combining model parameter with add parameter of BeanEditor or BeanEditForm
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1088.
--------------------------------------
Fix Version/s: 5.2.0
Resolution: Fixed
> Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.0
>
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property when
combining model parameter with add parameter of BeanEditor or BeanEditForm
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1088:
---------------------------------------
Summary: Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm (was: Bean editor model for <class name> already contains a property model for property <property name>)
So much for my theory about parameters; I have verified with the debugger that they are working correctly.
However, that makes me wonder what's going on in your situation? It seems that the combination of the model parameter and the other parameters is what's toxic. However, the test case in the patch isn't for that scenario (its the default generate model, without explicitly binding the model parameter).
I think the correct solution here is that add, reorder, include, remove are applied ONLY if the model parameter is not bound. This applies to BeanEditor, BeanEditForm and Grid.
> Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
Test case to reproduce the exception
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Test
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: (was: 0001-Fix-for-TAP5-1088.patch)
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1088:
------------------------------------------
Assignee: Howard M. Lewis Ship
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Issue Type: Bug (was: Test)
I consider this is a bug. Could somebody verify and apply the patch?
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Fix-for-TAP5-1088.patch, 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TAP5-1088) Bean editor model for
already contains a property model for property
when combining model parameter with add parameter of BeanEditor or
BeanEditForm
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863550#action_12863550 ]
Howard M. Lewis Ship edited comment on TAP5-1088 at 5/3/10 6:42 PM:
--------------------------------------------------------------------
So much for my theory about parameters; I have verified with the debugger that they are working correctly.
However, that makes me wonder what's going on in your situation? It seems that the combination of the model parameter and the other parameters is what's toxic. However, the test case in the patch isn't for that scenario (its the default generate model, without explicitly binding the model parameter).
I think the correct solution here is that add, reorder, include, remove are applied ONLY if the model parameter is not bound. This applies to BeanEditor, BeanEditForm, BeanDisplay and Grid.
was (Author: hlship):
So much for my theory about parameters; I have verified with the debugger that they are working correctly.
However, that makes me wonder what's going on in your situation? It seems that the combination of the model parameter and the other parameters is what's toxic. However, the test case in the patch isn't for that scenario (its the default generate model, without explicitly binding the model parameter).
I think the correct solution here is that add, reorder, include, remove are applied ONLY if the model parameter is not bound. This applies to BeanEditor, BeanEditForm and Grid.
> Bean editor model for <class name> already contains a property model for property <property name> when combining model parameter with add parameter of BeanEditor or BeanEditForm
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Attachment: 0001-Test-and-fix-for-TAP5-1088.diff
Test and fix in unified diff format
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Test-and-fix-for-TAP5-1088.diff, 0001-Test-and-fix-for-TAP5-1088.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1088) Bean editor model for
already contains a property model for property
Posted by "Dmitry Gusev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Gusev updated TAP5-1088:
-------------------------------
Issue Type: Bug (was: Test)
I consider this is a bug. Could somebody verify and apply the patch?
> Bean editor model for <class name> already contains a property model for property <property name>
> -------------------------------------------------------------------------------------------------
>
> Key: TAP5-1088
> URL: https://issues.apache.org/jira/browse/TAP5-1088
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Dmitry Gusev
> Attachments: 0001-Fix-for-TAP5-1088.patch, 0001-TestCase-illustrating-bug-with-bean-editor-model.patch
>
>
> I'm getting exception in my app:
> Render queue error in SetupRender[Details:itemeditor]: Bean editor model for org.apache.tapestry5.integration.app7.data.Item already contains a property model for property 'displayName'.
> Not sure if this is a bug or my misunderstanding of some T5 concepts.
> Here is my use case:
> I have 'Index' page displaying a list of items in a grid. Every row in the grid has an 'Edit' link (pagelink) that leads to 'Details' page where I can edit selected item using BeanEditor component. After clicking Submit application should redirect me back to 'Index' page where I can see the list with updated item. I may want to click 'Edit' once again and repeat the use case, but now at this place I get an exception I noted above.
> Here's my 'Item' class:
> package org.apache.tapestry5.integration.app7.data;
> public class Item {
> private int id;
>
> public Item(int id) {
> this.id = id;
> }
> public int getId() {
> return id;
> }
>
> public void setId(int id) {
> this.id = id;
> }
> public String getDisplayName() {
> return "Item #" + id;
> }
> }
> and a part of beaneditor markup on Details page:
> <t:beaneditor t:id="itemEditor" object="item" add="displayName"
> submitLabel="Apply Edit">
> You can see I declare new property (displayName) for the Item bean model. This works fine the first time I navigate to the Details page, but fails on the second time.
> To illustrate the exception I wrote a simple test case (see attachment). I took app6 integration test of tapestry-core tests as a reference (from trunk version on github) and implemented the test case in a new test application (app7).
> Hope this will help to understand the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.