You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/08/14 12:14:58 UTC

[GitHub] flink pull request #4539: [FLINK-7443] [metrics] MetricFetcher store and des...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4539

    [FLINK-7443] [metrics] MetricFetcher store and deserializer fields now final

    The MetricStore and MetricDumpDeserializer fields in the MetricFetcher should be final, as they are not meant to be overwritten and are even used for synchronization.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4539.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4539
    
----
commit 476b6d3055055c5b40eb6c3ee68ebb6c2f21165b
Author: zentol <ch...@apache.org>
Date:   2017-08-14T12:12:51Z

    [FLINK-7443] [metrics] MetricFetcher store and deserializer fields now final

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4539: [FLINK-7443] [metrics] MetricFetcher store and des...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4539


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4539: [FLINK-7443] [metrics] MetricFetcher store and deserializ...

Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4539
  
    +1 but I'm only seeing an improvement and not a bug


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4539: [FLINK-7443] [metrics] MetricFetcher store and deserializ...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4539
  
    true, will change the jira category. merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---