You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Karl Heinz Marbaise <kh...@gmx.de> on 2017/12/29 10:10:36 UTC
Maven 3.5.3: MNG-6305
Hi,
I would like to know if there are any objections to merge MNG-6305 into
master (Jenkins is fine [1]).
Kind regards
Karl Heinz Marbaise
[1]:
https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven 3.5.3: MNG-6305
Posted by Robert Scholte <rf...@apache.org>.
+1 to merge with the latest commits.
Robert
On Sat, 30 Dec 2017 19:12:31 +0100, Robert Scholte <rf...@apache.org>
wrote:
> Hi Karl Heinz,
>
> Please verify my commit.
>
> thanks,
> Robert
>
> On Sat, 30 Dec 2017 18:36:29 +0100, Karl Heinz Marbaise
> <kh...@gmx.de> wrote:
>
>> Hi,
>>
>>
>> On 30/12/17 18:33, Robert Scholte wrote:
>>> Sure, let me pick this up
>>
>> I have already implemented different solutions but based on performance
>> measurements the one I have implemented seemed to be the fastest
>> solution ?...
>>
>>
>> Kind regards
>> Karl Heinz Marbaise
>>> Robert
>>> On Sat, 30 Dec 2017 15:15:41 +0100, Karl Heinz Marbaise
>>> <kh...@gmx.de> wrote:
>>>
>>>> Hi Robert,
>>>>
>>>> On 29/12/17 11:18, Robert Scholte wrote:
>>>>> Hi Karl Heinz,
>>>>> I think the REgExp usage can be improved.
>>>>> Now it used for building up a new String followed by searching, I
>>>>> would expect that searching for ${(.+)} groups to be more efficient.
>>>>
>>>> Do you have some suggestions what you exactly have in mind?
>>>>
>>>> Kind regards
>>>> Karl Heinz Marbaise
>>>>> thanks,
>>>>> Robert
>>>>> On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
>>>>> <kh...@gmx.de> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I would like to know if there are any objections to merge MNG-6305
>>>>>> into master (Jenkins is fine [1]).
>>>>>>
>>>>>> Kind regards
>>>>>> Karl Heinz Marbaise
>>>>>>
>>>>>> [1]:
>>>>>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven 3.5.3: MNG-6305
Posted by Robert Scholte <rf...@apache.org>.
Hi Karl Heinz,
Please verify my commit.
thanks,
Robert
On Sat, 30 Dec 2017 18:36:29 +0100, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi,
>
>
> On 30/12/17 18:33, Robert Scholte wrote:
>> Sure, let me pick this up
>
> I have already implemented different solutions but based on performance
> measurements the one I have implemented seemed to be the fastest
> solution ?...
>
>
> Kind regards
> Karl Heinz Marbaise
>> Robert
>> On Sat, 30 Dec 2017 15:15:41 +0100, Karl Heinz Marbaise
>> <kh...@gmx.de> wrote:
>>
>>> Hi Robert,
>>>
>>> On 29/12/17 11:18, Robert Scholte wrote:
>>>> Hi Karl Heinz,
>>>> I think the REgExp usage can be improved.
>>>> Now it used for building up a new String followed by searching, I
>>>> would expect that searching for ${(.+)} groups to be more efficient.
>>>
>>> Do you have some suggestions what you exactly have in mind?
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>> thanks,
>>>> Robert
>>>> On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
>>>> <kh...@gmx.de> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I would like to know if there are any objections to merge MNG-6305
>>>>> into master (Jenkins is fine [1]).
>>>>>
>>>>> Kind regards
>>>>> Karl Heinz Marbaise
>>>>>
>>>>> [1]:
>>>>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven 3.5.3: MNG-6305
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi,
On 30/12/17 18:33, Robert Scholte wrote:
> Sure, let me pick this up
I have already implemented different solutions but based on performance
measurements the one I have implemented seemed to be the fastest
solution ?...
Kind regards
Karl Heinz Marbaise
>
> Robert
>
> On Sat, 30 Dec 2017 15:15:41 +0100, Karl Heinz Marbaise
> <kh...@gmx.de> wrote:
>
>> Hi Robert,
>>
>> On 29/12/17 11:18, Robert Scholte wrote:
>>> Hi Karl Heinz,
>>> I think the REgExp usage can be improved.
>>> Now it used for building up a new String followed by searching, I
>>> would expect that searching for ${(.+)} groups to be more efficient.
>>
>> Do you have some suggestions what you exactly have in mind?
>>
>> Kind regards
>> Karl Heinz Marbaise
>>> thanks,
>>> Robert
>>> On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
>>> <kh...@gmx.de> wrote:
>>>
>>>> Hi,
>>>>
>>>> I would like to know if there are any objections to merge MNG-6305
>>>> into master (Jenkins is fine [1]).
>>>>
>>>> Kind regards
>>>> Karl Heinz Marbaise
>>>>
>>>> [1]:
>>>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
>>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven 3.5.3: MNG-6305
Posted by Robert Scholte <rf...@apache.org>.
Sure, let me pick this up
Robert
On Sat, 30 Dec 2017 15:15:41 +0100, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi Robert,
>
> On 29/12/17 11:18, Robert Scholte wrote:
>> Hi Karl Heinz,
>> I think the REgExp usage can be improved.
>> Now it used for building up a new String followed by searching, I would
>> expect that searching for ${(.+)} groups to be more efficient.
>
> Do you have some suggestions what you exactly have in mind?
>
> Kind regards
> Karl Heinz Marbaise
>> thanks,
>> Robert
>> On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
>> <kh...@gmx.de> wrote:
>>
>>> Hi,
>>>
>>> I would like to know if there are any objections to merge MNG-6305
>>> into master (Jenkins is fine [1]).
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>> [1]:
>>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven 3.5.3: MNG-6305
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Robert,
On 29/12/17 11:18, Robert Scholte wrote:
> Hi Karl Heinz,
>
> I think the REgExp usage can be improved.
> Now it used for building up a new String followed by searching, I would
> expect that searching for ${(.+)} groups to be more efficient.
Do you have some suggestions what you exactly have in mind?
Kind regards
Karl Heinz Marbaise
>
> thanks,
> Robert
>
>
> On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
> <kh...@gmx.de> wrote:
>
>> Hi,
>>
>> I would like to know if there are any objections to merge MNG-6305
>> into master (Jenkins is fine [1]).
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> [1]:
>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven 3.5.3: MNG-6305
Posted by Robert Scholte <rf...@apache.org>.
Hi Karl Heinz,
I think the REgExp usage can be improved.
Now it used for building up a new String followed by searching, I would
expect that searching for ${(.+)} groups to be more efficient.
thanks,
Robert
On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
<kh...@gmx.de> wrote:
> Hi,
>
> I would like to know if there are any objections to merge MNG-6305 into
> master (Jenkins is fine [1]).
>
> Kind regards
> Karl Heinz Marbaise
>
> [1]:
> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org