You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tim Thorpe <tt...@ca.ibm.com> on 2015/11/09 16:47:46 UTC
Review Request 40082: AMBARI-9363: role_command_order.json should not
be at stack level
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40082/
-----------------------------------------------------------
Review request for Ambari and Sumit Mohanty.
Bugs: AMBARI-9363
https://issues.apache.org/jira/browse/AMBARI-9363
Repository: ambari
Description
-------
In current stack definitions, role_command_order.json is at the stack level.
For example: HDP/2.2/role_command_order.json
Service definitions are all nicely separated into different directories, like HDP/2.2/services/
{HDFS|YARN}
, but not the role_command_order. It would be neater to separate role_command_order per service and would be very useful while adding a new service to Ambari.
Looking for something as below,
HDP/2.2/services/HDFS/role_command_order.json
HDP/2.2/services/YARN/role_command_order.json
Ambari server while starting should merge all role_command_order.json and create dependencies accordingly.
This is extremely useful for custom services which are potentially added after the cluster install.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6bf917aebf1f5018217166e08e1f773f76
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java e7918591423e0a2e26d439e72d1a4d078ae7f53d
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 1e76b6bcc5c5dc641fa74386a3f855695a9cb7e4
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/role_command_order.json PRE-CREATION
Diff: https://reviews.apache.org/r/40082/diff/
Testing
-------
Running org.apache.ambari.server.stack.StackManagerTest
Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.027 sec
Thanks,
Tim Thorpe
Re: Review Request 40082: AMBARI-9363: role_command_order.json should
not be at stack level
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40082/#review107839
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java (line 120)
<https://reviews.apache.org/r/40082/#comment167165>
Let's add { and } to the if and else blocks.
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java (line 123)
<https://reviews.apache.org/r/40082/#comment167166>
What happens if both the parent and child define the same value?
ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java (line 149)
<https://reviews.apache.org/r/40082/#comment167164>
Indentation is off here.
- Alejandro Fernandez
On Nov. 9, 2015, 3:47 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40082/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 3:47 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-9363
> https://issues.apache.org/jira/browse/AMBARI-9363
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In current stack definitions, role_command_order.json is at the stack level.
> For example: HDP/2.2/role_command_order.json
>
> Service definitions are all nicely separated into different directories, like HDP/2.2/services/
> {HDFS|YARN}
>
> , but not the role_command_order. It would be neater to separate role_command_order per service and would be very useful while adding a new service to Ambari.
>
> Looking for something as below,
>
> HDP/2.2/services/HDFS/role_command_order.json
> HDP/2.2/services/YARN/role_command_order.json
> Ambari server while starting should merge all role_command_order.json and create dependencies accordingly.
>
> This is extremely useful for custom services which are potentially added after the cluster install.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6bf917aebf1f5018217166e08e1f773f76
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java e7918591423e0a2e26d439e72d1a4d078ae7f53d
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 1e76b6bcc5c5dc641fa74386a3f855695a9cb7e4
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/role_command_order.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40082/diff/
>
>
> Testing
> -------
>
> Running org.apache.ambari.server.stack.StackManagerTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.027 sec
>
>
> Thanks,
>
> Tim Thorpe
>
>
Re: Review Request 40082: AMBARI-9363: role_command_order.json should
not be at stack level
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Nov. 13, 2015, 11:01 p.m., Jayush Luniya wrote:
> > Ship It!
Committed patch to trunk. @Tim, can you close the review?
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40082/#review106517
-----------------------------------------------------------
On Nov. 9, 2015, 3:47 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40082/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 3:47 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-9363
> https://issues.apache.org/jira/browse/AMBARI-9363
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In current stack definitions, role_command_order.json is at the stack level.
> For example: HDP/2.2/role_command_order.json
>
> Service definitions are all nicely separated into different directories, like HDP/2.2/services/
> {HDFS|YARN}
>
> , but not the role_command_order. It would be neater to separate role_command_order per service and would be very useful while adding a new service to Ambari.
>
> Looking for something as below,
>
> HDP/2.2/services/HDFS/role_command_order.json
> HDP/2.2/services/YARN/role_command_order.json
> Ambari server while starting should merge all role_command_order.json and create dependencies accordingly.
>
> This is extremely useful for custom services which are potentially added after the cluster install.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6bf917aebf1f5018217166e08e1f773f76
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java e7918591423e0a2e26d439e72d1a4d078ae7f53d
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 1e76b6bcc5c5dc641fa74386a3f855695a9cb7e4
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/role_command_order.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40082/diff/
>
>
> Testing
> -------
>
> Running org.apache.ambari.server.stack.StackManagerTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.027 sec
>
>
> Thanks,
>
> Tim Thorpe
>
>
Re: Review Request 40082: AMBARI-9363: role_command_order.json should
not be at stack level
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40082/#review106517
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Nov. 9, 2015, 3:47 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40082/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 3:47 p.m.)
>
>
> Review request for Ambari and Sumit Mohanty.
>
>
> Bugs: AMBARI-9363
> https://issues.apache.org/jira/browse/AMBARI-9363
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In current stack definitions, role_command_order.json is at the stack level.
> For example: HDP/2.2/role_command_order.json
>
> Service definitions are all nicely separated into different directories, like HDP/2.2/services/
> {HDFS|YARN}
>
> , but not the role_command_order. It would be neater to separate role_command_order per service and would be very useful while adding a new service to Ambari.
>
> Looking for something as below,
>
> HDP/2.2/services/HDFS/role_command_order.json
> HDP/2.2/services/YARN/role_command_order.json
> Ambari server while starting should merge all role_command_order.json and create dependencies accordingly.
>
> This is extremely useful for custom services which are potentially added after the cluster install.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6bf917aebf1f5018217166e08e1f773f76
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java e7918591423e0a2e26d439e72d1a4d078ae7f53d
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 1e76b6bcc5c5dc641fa74386a3f855695a9cb7e4
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/role_command_order.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40082/diff/
>
>
> Testing
> -------
>
> Running org.apache.ambari.server.stack.StackManagerTest
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.027 sec
>
>
> Thanks,
>
> Tim Thorpe
>
>