[GitHub] [activemq-artemis] ehsavoie commented on a diff in pull request #4628: ARTEMIS-4436 Artemis is logging warnings during clean shutdown of server in cluster.

["ehsavoie (via GitHub)" <gi...@apache.org>]

ehsavoie commented on code in PR #4628:
URL: https://github.com/apache/activemq-artemis/pull/4628#discussion_r1338336447


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -1593,4 +1593,10 @@ void noQueueIdDefined(org.apache.activemq.artemis.api.core.Message message,
 
    @LogMessage(id = 224130, value = "The {} value {} will override the {} value {} since both are set.", level = LogMessage.Level.INFO)
    void configParamOverride(String overridingParam, Object overridingParamValue, String overriddenParam, Object overriddenParamValue);
+
+   @LogMessage(id = 224131, value = "Connection closed with failedOver={}", level = LogMessage.Level.INFO)
+   void bridgeConnectionClosed(Boolean failedOver);
+
+   @LogMessage(id = 224132, value = "There is a possible split brain on nodeID {} closing. Topology update ignored", level = LogMessage.Level.INFO)
+   void possibleSplitBrainAfterClosing(String nodeID);

Review Comment:
   Correct, this should go



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org