You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/20 12:31:53 UTC
[GitHub] [echarts] pissang opened a new pull request #14722: chore: enhance github workflow
pissang opened a new pull request #14722:
URL: https://github.com/apache/echarts/pull/14722
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
1. Fix jest failes on `node_modules/zrender`
2. Remove `canvas` from devDependency, which is always failed on install.
3. Not install zrender from GitHub in the workflow. Always test on the version in the dependency.
4. Add DTS check for earlier versions of TypeScript.
5. Remove template string in the exported type. Avoid type error in the earlier versions of TypeScript. #14716
6. Cache node_modules in the workflow to speedup the runner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14722: chore: enhance github workflow
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14722:
URL: https://github.com/apache/echarts/pull/14722#issuecomment-823238524
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14722: chore: enhance github workflow
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14722:
URL: https://github.com/apache/echarts/pull/14722#issuecomment-823235005
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #14722: chore: enhance github workflow
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14722:
URL: https://github.com/apache/echarts/pull/14722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org