You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2023/01/17 02:26:18 UTC
[GitHub] [incubator-uniffle] zuston opened a new issue, #493: [Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths
zuston opened a new issue, #493:
URL: https://github.com/apache/incubator-uniffle/issues/493
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
This problem is mentioned by previous PR https://github.com/apache/incubator-uniffle/pull/481#discussion_r1070752457.
The invoking of `putIfAbsent` will always call its value if it's a time-consuming operation. So we'd better replace putIfAbsent with computeIfAbsent in some critical paths.
### How should we improve?
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] Pushkarmondal commented on issue #493: [Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths
Posted by "Pushkarmondal (via GitHub)" <gi...@apache.org>.
Pushkarmondal commented on issue #493:
URL: https://github.com/apache/incubator-uniffle/issues/493#issuecomment-1415410030
is this issue resolved?
Hey how can I contribute to this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #493: [Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #493:
URL: https://github.com/apache/incubator-uniffle/issues/493#issuecomment-1408149595
https://github.com/apache/incubator-uniffle/issues/519 these two issues should be considered together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston closed issue #493: [Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #493: [Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths
URL: https://github.com/apache/incubator-uniffle/issues/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] cchung100m commented on issue #493: [Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths
Posted by "cchung100m (via GitHub)" <gi...@apache.org>.
cchung100m commented on issue #493:
URL: https://github.com/apache/incubator-uniffle/issues/493#issuecomment-1542299303
Hi @zuston
I'd like to handle this issue if you agreed. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #493: [Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #493:
URL: https://github.com/apache/incubator-uniffle/issues/493#issuecomment-1543208732
@cchung100m Assigned. Thanks in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org