You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by dmabry <gi...@git.apache.org> on 2017/02/27 20:48:19 UTC
[GitHub] cloudstack pull request #1973: CLOUDSTACK-9795: moved logrotate from cron.da...
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/1973
CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for vpcrouter
[BACKPORT PR1954]
moved logrotate from cron.daily to cron.hourly for vpcrouter in cloud-early-config. This brings 'vpcrouter' inline with 'router'. We are having issues with cloud.log not rotating fast enough, which filled up /var/log and ultimately caused the VR to stop functioning in such a way that it prevented new VMs from being deployed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA/cloudstack bug/4.8-vpc-vr-logrotate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1973
----
commit 825cb5a0b68ddbf3195ba591ac433bac10189495
Author: David Mabry <dm...@ena.com>
Date: 2017-02-27T20:44:57Z
Backport of PR 1954 [CLOUDSTACK-9795]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1973: CLOUDSTACK-9795: moved logrotate from cron.da...
Posted by dmabry <gi...@git.apache.org>.
Github user dmabry closed the pull request at:
https://github.com/apache/cloudstack/pull/1973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...
Posted by dmabry <gi...@git.apache.org>.
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1973
Did a git cherry-pick as suggested by @rafaelweingartner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1973
@dmabry as I posted on the other PR, I only suggested `git cherry-pick` because I thought it would preserve the commit hash. It was a misunderstanding from me. The git hash is generated based on parent commit as well as other bits of information. Therefore, even when using `git cherry-pick` the hash of commits between branches will always be different (unless a hash collision happens).
The `git cherry-pick` is quite useful when you have to apply a bunch of changes, but in your case, I do not think you need it. The way you did before was ok.
BTW: I think a single commit to introduce these changes is enough ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1973: CLOUDSTACK-9795: moved logrotate from cron.daily to ...
Posted by dmabry <gi...@git.apache.org>.
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1973
Closing PR as it will be cherry-picked from master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---