You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by pk...@apache.org on 2026/07/28 18:17:24 UTC

(logging-flume) branch trunk updated: Make TestRateLimiter locale-independent (#469)

This is an automated email from the ASF dual-hosted git repository.

ppkarwasz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/logging-flume.git


The following commit(s) were added to refs/heads/trunk by this push:
     new b4fcd518 Make TestRateLimiter locale-independent (#469)
b4fcd518 is described below

commit b4fcd518cc8ba53527433bdf885f3bbe054fa3e6
Author: Piotr P. Karwasz <pk...@apache.org>
AuthorDate: Tue Jul 28 20:17:18 2026 +0200

    Make TestRateLimiter locale-independent (#469)
    
    The vendored Guava test formatted expected events with the default
    locale, so it failed on JVMs using a comma decimal separator.
    
    Assisted-By: Claude Fable 5 <no...@anthropic.com>
---
 .../java/org/apache/flume/source/shaded/guava/TestRateLimiter.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/flume-ng-core/src/test/java/org/apache/flume/source/shaded/guava/TestRateLimiter.java b/flume-ng-core/src/test/java/org/apache/flume/source/shaded/guava/TestRateLimiter.java
index ac0ea41d..3899cf0b 100644
--- a/flume-ng-core/src/test/java/org/apache/flume/source/shaded/guava/TestRateLimiter.java
+++ b/flume-ng-core/src/test/java/org/apache/flume/source/shaded/guava/TestRateLimiter.java
@@ -23,6 +23,7 @@ import static java.util.concurrent.TimeUnit.SECONDS;
 import com.google.common.collect.Lists;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Locale;
 import java.util.Random;
 import junit.framework.TestCase;
 import org.apache.flume.source.shaded.guava.RateLimiter.SleepingStopwatch;
@@ -428,7 +429,7 @@ public class TestRateLimiter extends TestCase {
 
         void sleepMicros(String caption, long micros) {
             instant += MICROSECONDS.toNanos(micros);
-            events.add(caption + String.format("%3.2f", (micros / 1000000.0)));
+            events.add(caption + String.format(Locale.ROOT, "%3.2f", (micros / 1000000.0)));
         }
 
         @Override