You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/11/24 06:56:22 UTC
[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/467
Add basic documentation for Markdown
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin markdownDocUpdate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/467.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #467
----
commit e4293554c6cc81f482629c7f427259a430ae12b3
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-11-24T05:38:30Z
Add basic documentation for Markdown
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/467#issuecomment-160054307
Looks good to me. CI build failing is irrelevant.
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/467#issuecomment-159186628
looks good. we use markdown4j you might want to link to https://code.google.com/p/markdown4j/ for additional extension it supports
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/467#issuecomment-159780154
Because of changes introduced by https://issues.apache.org/jira/browse/ZEPPELIN-445,
You'll need to change menu, too
https://github.com/apache/incubator-zeppelin/blob/master/docs/_includes/themes/zeppelin/_navigation.html#L43
And asset path need to be
{{BASE_PATH}}/assets/themes/zeppelin/img/docs-img/markdown-interpreter-setting.png
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/467#issuecomment-159569705
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add basic documentation for Markd...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/467#issuecomment-159509640
@felixcheung thanks for the suggestion. I've included the markdown4j link in d839992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---