You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/01 09:45:59 UTC
[GitHub] [flink] rmetzger opened a new pull request #14272: FLINK-20426][docs] Fix broken links after Hadoop page removal
rmetzger opened a new pull request #14272:
URL: https://github.com/apache/flink/pull/14272
## What is the purpose of the change
I recently removed the Hadoop page, and forgot to fix some missing links.
I also didn't properly update the translated pages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736367051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1574a0979dce3046d619573b6e466475028516cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371",
"triggerID" : "1574a0979dce3046d619573b6e466475028516cb",
"triggerType" : "PUSH"
}, {
"hash" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378",
"triggerID" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"triggerType" : "PUSH"
}, {
"hash" : "74361019570ec812a1b9e9fd47e12945cc1b3e8a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10387",
"triggerID" : "74361019570ec812a1b9e9fd47e12945cc1b3e8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c6ca708974068e8aeeee6da537fb04b306bb909c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378)
* 74361019570ec812a1b9e9fd47e12945cc1b3e8a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10387)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736597590
Thanks, merging ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14272: FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736361495
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1574a0979dce3046d619573b6e466475028516cb (Tue Dec 01 09:48:22 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736367051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1574a0979dce3046d619573b6e466475028516cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371",
"triggerID" : "1574a0979dce3046d619573b6e466475028516cb",
"triggerType" : "PUSH"
}, {
"hash" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1574a0979dce3046d619573b6e466475028516cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371)
* c6ca708974068e8aeeee6da537fb04b306bb909c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #14272:
URL: https://github.com/apache/flink/pull/14272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736539777
Thanks for your review. I addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #14272:
URL: https://github.com/apache/flink/pull/14272#discussion_r533364585
##########
File path: docs/deployment/resource-providers/yarn.zh.md
##########
@@ -78,7 +78,7 @@ Congratulations! You have successfully run a Flink application by deploying Flin
## Deployment Modes Supported by Flink on YARN
-For production use, we recommend deploying Flink Applications in the [Per-job or Application Mode]({% link deployment/index.md %}#deployment-modes), as these modes provide a better isolation for the Applications.
+For production use, we recommend deploying Flink Applications in the [Per-job or Application Mode]({% link deployment/index.zh.md %}#deployment-modes), as these modes provide a better isolation for the Applications.
Review comment:
```suggestion
For production use, we recommend deploying Flink Applications in the [Per-Job or Application Mode]({% link deployment/index.zh.md %}#deployment-modes), as these modes provide a better isolation for the Applications.
```
##########
File path: docs/dev/batch/hadoop_compatibility.md
##########
@@ -64,7 +64,17 @@ and Reducers.
</dependency>
{% endhighlight %}
-See also **[how to configure hadoop dependencies]({{ site.baseurl }}/deployment/resource-providers/hadoop.html#add-hadoop-classpaths)**.
+If you want to run your Flink application locally (from your IDE), you also need to add
Review comment:
```suggestion
If you want to run your Flink application locally (e.g. from your IDE), you also need to add
```
##########
File path: docs/dev/project-configuration.zh.md
##########
@@ -152,8 +152,12 @@ for details on how to build Flink for a specific Scala version.
*(The only exception being when using existing Hadoop input-/output formats with Flink's Hadoop compatibility wrappers)*
If you want to use Flink with Hadoop, you need to have a Flink setup that includes the Hadoop dependencies, rather than
-adding Hadoop as an application dependency. Please refer to the [Hadoop Setup Guide]({{ site.baseurl }}/deployment/resource-providers/hadoop.html)
-for details.
+adding Hadoop as an application dependency. Flink will use the Hadoop dependencies specified by the `HADOOP_CLASSPATH`
+environment variable, which can usually be set by calling:
Review comment:
```suggestion
environment variable, which can be set in the following way:
```
Minor thing: It's just that I would "call" a program but not a variable setting.
##########
File path: docs/dev/project-configuration.md
##########
@@ -152,8 +152,12 @@ for details on how to build Flink for a specific Scala version.
*(The only exception being when using existing Hadoop input-/output formats with Flink's Hadoop compatibility wrappers)*
If you want to use Flink with Hadoop, you need to have a Flink setup that includes the Hadoop dependencies, rather than
-adding Hadoop as an application dependency. Please refer to the [Hadoop Setup Guide]({{ site.baseurl }}/deployment/resource-providers/hadoop.html)
-for details.
+adding Hadoop as an application dependency. Flink will use the Hadoop dependencies specified by the `HADOOP_CLASSPATH`
+environment variable, which can usually be set by calling
Review comment:
```suggestion
environment variable, which can be set in the following way:
```
Minor thing: It's just that I would "call" a program but not a variable setting.
##########
File path: docs/dev/batch/hadoop_compatibility.zh.md
##########
@@ -64,7 +64,17 @@ and Reducers.
</dependency>
{% endhighlight %}
-See also **[how to configure hadoop dependencies]({{ site.baseurl }}/deployment/resource-providers/hadoop.html#add-hadoop-classpaths)**.
+If you want to run your Flink application locally (from your IDE), you also need to add
Review comment:
```suggestion
If you want to run your Flink application locally (e.g. from your IDE), you also need to add
```
##########
File path: docs/dev/table/connectors/hive/index.md
##########
@@ -92,8 +92,11 @@ to make the integration work in Table API program or SQL in SQL Client.
Alternatively, you can put these dependencies in a dedicated folder, and add them to classpath with the `-C`
or `-l` option for Table API program or SQL Client respectively.
-Apache Hive is built on Hadoop, so you need Hadoop dependency first, please refer to
-[Providing Hadoop classes]({{ site.baseurl }}/deployment/resource-providers/hadoop.html#providing-hadoop-classes).
+Apache Hive is built on Hadoop, so you need to provide Hadoop dependenies, by setting the `HADOOP_CLASSPATH`
Review comment:
```suggestion
Apache Hive is built on Hadoop, so you need to provide Hadoop dependencies by setting the `HADOOP_CLASSPATH`
```
##########
File path: docs/deployment/resource-providers/yarn.zh.md
##########
@@ -78,7 +78,7 @@ Congratulations! You have successfully run a Flink application by deploying Flin
## Deployment Modes Supported by Flink on YARN
-For production use, we recommend deploying Flink Applications in the [Per-job or Application Mode]({% link deployment/index.md %}#deployment-modes), as these modes provide a better isolation for the Applications.
+For production use, we recommend deploying Flink Applications in the [Per-job or Application Mode]({% link deployment/index.zh.md %}#deployment-modes), as these modes provide a better isolation for the Applications.
Review comment:
There's another occurrence in the first sentence of the `Per-Job Cluster Mode` section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14272: FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736367051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1574a0979dce3046d619573b6e466475028516cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1574a0979dce3046d619573b6e466475028516cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1574a0979dce3046d619573b6e466475028516cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736564118
This works for me (from docker, accessing with Google Chrome). Are you sure your browser is not caching anything?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14272: FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736367051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1574a0979dce3046d619573b6e466475028516cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371",
"triggerID" : "1574a0979dce3046d619573b6e466475028516cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1574a0979dce3046d619573b6e466475028516cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736592008
> The navigation bar works for me as well. Maybe try firing a full jekyll build? If you run only the incremental build it might not update all the pages.
>
> (Just if you're wondering. I am monitoring this issue as I am interested in it in the context of #14235 )
Thanks for supporting us here, @dawidwys . It works for me now having all docs build. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736367051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1574a0979dce3046d619573b6e466475028516cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371",
"triggerID" : "1574a0979dce3046d619573b6e466475028516cb",
"triggerType" : "PUSH"
}, {
"hash" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378",
"triggerID" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1574a0979dce3046d619573b6e466475028516cb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371)
* c6ca708974068e8aeeee6da537fb04b306bb909c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736590018
The navigation bar works for me as well. Maybe try firing a full jekyll build? If you run only the incremental build it might not update all the pages.
(Just if you're wondering. I am monitoring this issue as I am interested in it in the context of https://github.com/apache/flink/pull/14235 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736367051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1574a0979dce3046d619573b6e466475028516cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371",
"triggerID" : "1574a0979dce3046d619573b6e466475028516cb",
"triggerType" : "PUSH"
}, {
"hash" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378",
"triggerID" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c6ca708974068e8aeeee6da537fb04b306bb909c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14272: [FLINK-20426][docs] Fix broken links after Hadoop page removal
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14272:
URL: https://github.com/apache/flink/pull/14272#issuecomment-736367051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1574a0979dce3046d619573b6e466475028516cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10371",
"triggerID" : "1574a0979dce3046d619573b6e466475028516cb",
"triggerType" : "PUSH"
}, {
"hash" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378",
"triggerID" : "c6ca708974068e8aeeee6da537fb04b306bb909c",
"triggerType" : "PUSH"
}, {
"hash" : "74361019570ec812a1b9e9fd47e12945cc1b3e8a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74361019570ec812a1b9e9fd47e12945cc1b3e8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c6ca708974068e8aeeee6da537fb04b306bb909c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10378)
* 74361019570ec812a1b9e9fd47e12945cc1b3e8a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org