You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/02/03 17:13:34 UTC
Review Request 56282: AMBARI-19867. Grafana install fails if custom
directory's parent does not exist
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56282/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Sebastian Toader, and Sid Wagle.
Bugs: AMBARI-19867
https://issues.apache.org/jira/browse/AMBARI-19867
Repository: ambari
Description
-------
Create parent directories.
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py c3bc600eda1e77ea99bc7d31cc31854d7bc3c1c3
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py 07b27a63d45e39848b0b619d7fd41bc43803bfc1
Diff: https://reviews.apache.org/r/56282/diff/
Testing
-------
Manual test on local cluster.
Unit tests:
```
$ mvn -am -pl ambari-server -DfailIfNoTests=false -DskipSurefireTests -Dcheckstyle.skip -Drat.skip clean test
...
Total run:1182
Total errors:0
Total failures:0
OK
...
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
Re: Review Request 56282: AMBARI-19867. Grafana install fails if
custom directory's parent does not exist
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56282/#review164129
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Feb. 3, 2017, 6:13 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56282/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 6:13 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sebastian Toader, and Sid Wagle.
>
>
> Bugs: AMBARI-19867
> https://issues.apache.org/jira/browse/AMBARI-19867
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create parent directories.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py c3bc600eda1e77ea99bc7d31cc31854d7bc3c1c3
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py 07b27a63d45e39848b0b619d7fd41bc43803bfc1
>
> Diff: https://reviews.apache.org/r/56282/diff/
>
>
> Testing
> -------
>
> Manual test on local cluster.
>
> Unit tests:
>
> ```
> $ mvn -am -pl ambari-server -DfailIfNoTests=false -DskipSurefireTests -Dcheckstyle.skip -Drat.skip clean test
> ...
> Total run:1182
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 56282: AMBARI-19867. Grafana install fails if
custom directory's parent does not exist
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56282/#review164128
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On Feb. 3, 2017, 5:13 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56282/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 5:13 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sebastian Toader, and Sid Wagle.
>
>
> Bugs: AMBARI-19867
> https://issues.apache.org/jira/browse/AMBARI-19867
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create parent directories.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py c3bc600eda1e77ea99bc7d31cc31854d7bc3c1c3
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py 07b27a63d45e39848b0b619d7fd41bc43803bfc1
>
> Diff: https://reviews.apache.org/r/56282/diff/
>
>
> Testing
> -------
>
> Manual test on local cluster.
>
> Unit tests:
>
> ```
> $ mvn -am -pl ambari-server -DfailIfNoTests=false -DskipSurefireTests -Dcheckstyle.skip -Drat.skip clean test
> ...
> Total run:1182
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] BUILD SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>