You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/03/30 18:56:46 UTC
[GitHub] couchdb-fauxton pull request: Ace Editor code update
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/346
Ace Editor code update
This makes two small changes to the Ace Editor component:
- adds an optional onChange callback
- lets the calling code choose to override the default manual
JS resizing of the editor. Going forward we can use flexbox to
handle all of that for us, which will let us drop a lot of the
unnecessary JS code to manually resize the editor based on
available space and window resizes, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton editor-tweaks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #346
----
commit e2b0c354cadc3832715b018691db50f4f4952c1f
Author: Ben Keen <be...@gmail.com>
Date: 2015-03-30T16:52:13Z
Ace Editor code update
This makes two small changes to the Ace Editor component:
- adds an optional onChange callback
- lets the calling code choose to override the default manual
JS resizing of the editor. Going forward we can use flexbox to
handle all of that for us, which will let us drop a lot of the
unnecessary JS code to manually resize the editor based on
available space and window resizes, etc.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Ace Editor code update
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/346#issuecomment-88117378
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Ace Editor code update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/346#issuecomment-87881768
Yes; Michelle merged a fix. I'll re-run all my PRs and see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Ace Editor code update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/346#issuecomment-88191437
Merged as 5d2fdcc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Ace Editor code update
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/346#issuecomment-87867444
Hey Ben,
seems the "Check Database Tooltip" test fails quite often, is it flaky?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Ace Editor code update
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---