Re: [PR] WIP: scalar UDFs with metadata [datafusion-python]

["kylebarron (via GitHub)" <gi...@apache.org>]

kylebarron commented on code in PR #1110:
URL: https://github.com/apache/datafusion-python/pull/1110#discussion_r2074464751


##########
python/datafusion/user_defined.py:
##########
@@ -77,6 +77,15 @@ def __str__(self) -> str:
         return self.name.lower()
 
 
+class ScalarUDFExportable(Protocol):
+    """Type hint for object that has __datafusion_table_provider__ PyCapsule.
+
+    https://datafusion.apache.org/python/user-guide/io/table_provider.html

Review Comment:
   Wrong link here



##########
python/datafusion/user_defined.py:
##########
@@ -77,6 +77,15 @@ def __str__(self) -> str:
         return self.name.lower()
 
 
+class ScalarUDFExportable(Protocol):
+    """Type hint for object that has __datafusion_table_provider__ PyCapsule.

Review Comment:
   ```suggestion
       """Type hint for object that has __datafusion_scalar_udf__ PyCapsule.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org