You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "guyuqi (via GitHub)" <gi...@apache.org> on 2024/06/24 02:39:26 UTC
[PR] [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build [incubator-gluten]
guyuqi opened a new pull request, #6190:
URL: https://github.com/apache/incubator-gluten/pull/6190
## What changes were proposed in this pull request?
SSE4.2 is always enabled in Project oap-project/libhdfs3 [Options.cmake](https://github.com/oap-project/libhdfs3/blob/master/CMake/Options.cmake#L3).
When building Gluten-Velox with enabling HDFS(--enable_hdfs=ON) on Arm64 Ubuntu, build issues occurred:
```
c++: error: unrecognized command-line option ‘-msse4.2’
ninja: build stopped: subcommand failed.
```
## How was this patch tested?
Build Gluten-Velox with --enable_hdfs=ON
./dev/builddeps-veloxbe.sh --build_tests=ON --build_benchmarks=ON --enable_hdfs=ON
libhdfs.so could be properly installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #6190:
URL: https://github.com/apache/incubator-gluten/pull/6190#discussion_r1650607439
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -137,7 +137,7 @@ function process_setup_centos8 {
sed -i '/^ run_and_time install_fbthrift/a \ run_and_time install_openssl' scripts/setup-centos8.sh
if [ $ENABLE_HDFS == "ON" ]; then
- sed -i '/^function install_gflags.*/i function install_libhdfs3 {\n cd "\${DEPENDENCY_DIR}"\n github_checkout oap-project/libhdfs3 master\n cmake_install\n}\n' scripts/setup-centos8.sh
+ sed -i '/^function install_gflags.*/i function install_libhdfs3 {\n cd "\${DEPENDENCY_DIR}"\n github_checkout oap-project/libhdfs3 master\n git apply ../../../src/modify_libhdfs3.patch\n cd ..\n cmake_install\n}\n' scripts/setup-centos8.sh
Review Comment:
can we use `CURRENT_DIR` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #6190:
URL: https://github.com/apache/incubator-gluten/pull/6190#discussion_r1650609120
##########
ep/build-velox/src/modify_libhdfs3.patch:
##########
Review Comment:
The libhdfs codebase is maintained by oap self. I'm wondering if we can push to libhdfs repo directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6190:
URL: https://github.com/apache/incubator-gluten/pull/6190#issuecomment-2278933225
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6190:
URL: https://github.com/apache/incubator-gluten/pull/6190#issuecomment-2300123453
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6190:
URL: https://github.com/apache/incubator-gluten/pull/6190#issuecomment-2185480105
https://github.com/apache/incubator-gluten/issues/3806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6190: [GLUTEN-3806][VL] Add Arm64 libhdfs3 support for velox build
URL: https://github.com/apache/incubator-gluten/pull/6190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org