You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "platoneko (via GitHub)" <gi...@apache.org> on 2024/03/14 11:17:05 UTC
[PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
platoneko opened a new pull request, #32257:
URL: https://github.com/apache/doris/pull/32257
## Proposed changes
Merge transient rowset state to rowset.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1998846254
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2006257258
TeamCity be ut coverage result:
Function Coverage: 35.31% (8727/24716)
Line Coverage: 27.13% (71397/263166)
Region Coverage: 26.38% (37046/140421)
Branch Coverage: 23.28% (18940/81356)
Coverage Report: http://coverage.selectdb-in.cc/coverage/72f6384c009a80ca7b503ee8cf1c3b31c953ecbb_72f6384c009a80ca7b503ee8cf1c3b31c953ecbb/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1997392932
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1997523056
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2006221192
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1997306911
<details>
<summary>TPC-H: <b>Total hot run time: 38059 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68d15caee9f0589d12df71982c3d9bbad7676349, data reload: false
------ Round 1 ----------------------------------
q1 17644 4301 4092 4092
q2 2020 154 144 144
q3 10592 1150 906 906
q4 7070 759 708 708
q5 7487 2699 2581 2581
q6 188 123 124 123
q7 1223 818 809 809
q8 9387 2065 2002 2002
q9 7165 6454 6410 6410
q10 8494 3495 3630 3495
q11 442 221 224 221
q12 633 306 296 296
q13 17790 2837 2853 2837
q14 270 257 246 246
q15 521 463 446 446
q16 497 390 388 388
q17 965 568 548 548
q18 7150 6529 6333 6333
q19 3856 1415 1472 1415
q20 542 281 276 276
q21 6369 3481 3537 3481
q22 352 302 332 302
Total cold run time: 110657 ms
Total hot run time: 38059 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4141 4041 4045 4041
q2 322 225 226 225
q3 3012 2840 2856 2840
q4 1864 1551 1561 1551
q5 5202 5234 5240 5234
q6 195 113 115 113
q7 2223 1879 1826 1826
q8 3140 3275 3241 3241
q9 8557 8543 8546 8543
q10 3685 3651 3643 3643
q11 547 433 434 433
q12 704 574 547 547
q13 16928 2870 2820 2820
q14 292 244 264 244
q15 469 451 443 443
q16 457 406 413 406
q17 1748 1466 1467 1466
q18 7516 7294 7095 7095
q19 1614 1472 1496 1472
q20 1915 1704 1717 1704
q21 4865 4818 4781 4781
q22 545 452 466 452
Total cold run time: 69941 ms
Total hot run time: 53120 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2006190350
TeamCity be ut coverage result:
Function Coverage: 35.31% (8726/24716)
Line Coverage: 27.12% (71366/263160)
Region Coverage: 26.38% (37035/140416)
Branch Coverage: 23.26% (18926/81352)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bd1e60d9b8da8a81a2ac37e58f30de59415ec185_bd1e60d9b8da8a81a2ac37e58f30de59415ec185/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2006191850
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2006203813
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1998849651
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32257:
URL: https://github.com/apache/doris/pull/32257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2006201199
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1997223926
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1997214667
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2006030389
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1998874337
<details>
<summary>TPC-H: <b>Total hot run time: 38495 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bd1e60d9b8da8a81a2ac37e58f30de59415ec185, data reload: false
------ Round 1 ----------------------------------
q1 17681 4221 4174 4174
q2 2020 151 139 139
q3 10604 1137 898 898
q4 7776 768 751 751
q5 7461 2817 2791 2791
q6 183 121 120 120
q7 1176 825 800 800
q8 9325 2075 2023 2023
q9 7280 6417 6457 6417
q10 8538 3478 3649 3478
q11 431 226 207 207
q12 624 292 299 292
q13 17779 2854 2854 2854
q14 270 241 248 241
q15 508 459 456 456
q16 515 395 389 389
q17 975 534 559 534
q18 7201 6533 6464 6464
q19 2863 1456 1415 1415
q20 547 291 281 281
q21 6239 3470 3528 3470
q22 356 301 306 301
Total cold run time: 110352 ms
Total hot run time: 38495 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4096 4056 4077 4056
q2 323 222 225 222
q3 3011 2847 2868 2847
q4 1875 1600 1539 1539
q5 5263 5245 5239 5239
q6 209 117 117 117
q7 2249 1839 1837 1837
q8 3182 3323 3285 3285
q9 8574 8608 8581 8581
q10 3727 3702 3649 3649
q11 537 444 455 444
q12 711 539 570 539
q13 16897 2871 2837 2837
q14 272 254 249 249
q15 488 455 452 452
q16 451 407 429 407
q17 1739 1499 1473 1473
q18 7532 7247 7068 7068
q19 1680 1549 1542 1542
q20 1910 1742 1707 1707
q21 4805 4695 4964 4695
q22 535 453 447 447
Total cold run time: 70066 ms
Total hot run time: 53232 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1997214814
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1997306706
TeamCity be ut coverage result:
Function Coverage: 34.99% (8572/24499)
Line Coverage: 26.73% (69450/259805)
Region Coverage: 26.01% (36069/138691)
Branch Coverage: 22.96% (18417/80208)
Coverage Report: http://coverage.selectdb-in.cc/coverage/68d15caee9f0589d12df71982c3d9bbad7676349_68d15caee9f0589d12df71982c3d9bbad7676349/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Fix wrong rowset state in partial update [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-2007301970
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](partial-update) Merge transient rowset state to rowset [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32257:
URL: https://github.com/apache/doris/pull/32257#issuecomment-1998877740
TeamCity be ut coverage result:
Function Coverage: 34.95% (8574/24531)
Line Coverage: 26.66% (69479/260587)
Region Coverage: 25.95% (36088/139046)
Branch Coverage: 22.91% (18428/80434)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bd1e60d9b8da8a81a2ac37e58f30de59415ec185_bd1e60d9b8da8a81a2ac37e58f30de59415ec185/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org