You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Richard Kettelerij (Created) (JIRA)" <ji...@apache.org> on 2012/03/12 16:00:38 UTC
[jira] [Created] (RAVE-509) Move Person repository from
rave-shindig to rave-core
Move Person repository from rave-shindig to rave-core
------------------------------------------------------
Key: RAVE-509
URL: https://issues.apache.org/jira/browse/RAVE-509
Project: Rave
Issue Type: Improvement
Components: rave-core, rave-shindig
Affects Versions: 0.8-INCUBATING
Reporter: Richard Kettelerij
Priority: Critical
Fix For: 0.10-INCUBATING
I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server (*).
Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.
(*) With OpenJPA as the persistence provider, no Hibernate involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-509) Move Person repository from
rave-shindig to rave-core
Posted by "Richard Kettelerij (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227586#comment-13227586 ]
Richard Kettelerij commented on RAVE-509:
-----------------------------------------
Patch created against trunk dd. 12-03-2012.
> Move Person repository from rave-shindig to rave-core
> ------------------------------------------------------
>
> Key: RAVE-509
> URL: https://issues.apache.org/jira/browse/RAVE-509
> Project: Rave
> Issue Type: Improvement
> Components: rave-core, rave-shindig
> Affects Versions: 0.8-INCUBATING
> Reporter: Richard Kettelerij
> Priority: Critical
> Fix For: 0.10-INCUBATING
>
> Attachments: rave_jpa_refactoring_trunk.patch
>
>
> I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server (*).
> Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
> With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.
> (*) With OpenJPA as the persistence provider, no Hibernate involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-509) Move Person repository from
rave-shindig to rave-core
Posted by "Richard Kettelerij (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235569#comment-13235569 ]
Richard Kettelerij commented on RAVE-509:
-----------------------------------------
Please let me know if you need more information or any other help. I would be great if this patch made it into the next (0.10) release.
> Move Person repository from rave-shindig to rave-core
> ------------------------------------------------------
>
> Key: RAVE-509
> URL: https://issues.apache.org/jira/browse/RAVE-509
> Project: Rave
> Issue Type: Improvement
> Components: rave-core, rave-shindig
> Affects Versions: 0.8-INCUBATING
> Reporter: Richard Kettelerij
> Priority: Critical
> Fix For: 0.10-INCUBATING
>
> Attachments: rave_jpa_refactoring_trunk.patch
>
>
> I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server (*).
> Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
> With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.
> (*) With OpenJPA as the persistence provider, no Hibernate involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (RAVE-509) Move Person repository
from rave-shindig to rave-core
Posted by "Richard Kettelerij (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235569#comment-13235569 ]
Richard Kettelerij edited comment on RAVE-509 at 3/22/12 1:19 PM:
------------------------------------------------------------------
Please let me know if you need more information or any other help. It would be great if this patch made it into the next (0.10) release.
was (Author: rkettelerij):
Please let me know if you need more information or any other help. I would be great if this patch made it into the next (0.10) release.
> Move Person repository from rave-shindig to rave-core
> ------------------------------------------------------
>
> Key: RAVE-509
> URL: https://issues.apache.org/jira/browse/RAVE-509
> Project: Rave
> Issue Type: Improvement
> Components: rave-core, rave-shindig
> Affects Versions: 0.8-INCUBATING
> Reporter: Richard Kettelerij
> Priority: Critical
> Fix For: 0.10-INCUBATING
>
> Attachments: rave_jpa_refactoring_trunk.patch
>
>
> I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server (*).
> Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
> With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.
> (*) With OpenJPA as the persistence provider, no Hibernate involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-509) Move Person repository from
rave-shindig to rave-core
Posted by "Richard Kettelerij (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Kettelerij updated RAVE-509:
------------------------------------
Attachment: rave_jpa_refactoring_trunk.patch
> Move Person repository from rave-shindig to rave-core
> ------------------------------------------------------
>
> Key: RAVE-509
> URL: https://issues.apache.org/jira/browse/RAVE-509
> Project: Rave
> Issue Type: Improvement
> Components: rave-core, rave-shindig
> Affects Versions: 0.8-INCUBATING
> Reporter: Richard Kettelerij
> Priority: Critical
> Fix For: 0.10-INCUBATING
>
> Attachments: rave_jpa_refactoring_trunk.patch
>
>
> I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server (*).
> Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
> With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.
> (*) With OpenJPA as the persistence provider, no Hibernate involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-509) Move Person repository from
rave-shindig to rave-core
Posted by "Jasha Joachimsthal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236610#comment-13236610 ]
Jasha Joachimsthal commented on RAVE-509:
-----------------------------------------
Hi Richard,
The OpenSocial Person can have a different persistence than the portal User. In our demo setup we have stored both in the same table. The portal retrieves the data as User, the OpenSocial container Shindig retrieves the data as Person.
Due to the refactored project setup of RAVE-524 your patch doesn't work anymore. Failing unit tests are imo not minor issues, but blocking for applying the patch.
What are the classloading errors in JBoss? Tomcat (6) doesn't seem to have them.
Jasha
> Move Person repository from rave-shindig to rave-core
> ------------------------------------------------------
>
> Key: RAVE-509
> URL: https://issues.apache.org/jira/browse/RAVE-509
> Project: Rave
> Issue Type: Improvement
> Components: rave-core, rave-shindig
> Affects Versions: 0.8-INCUBATING
> Reporter: Richard Kettelerij
> Priority: Critical
> Fix For: 0.10-INCUBATING
>
> Attachments: rave_jpa_refactoring_trunk.patch
>
>
> I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server (*).
> Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
> With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.
> (*) With OpenJPA as the persistence provider, no Hibernate involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-509) Move Person repository from
rave-shindig to rave-core
Posted by "Richard Kettelerij (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236673#comment-13236673 ]
Richard Kettelerij commented on RAVE-509:
-----------------------------------------
Hi Jasha,
Failing tests are indeed blocking. What I meant was; please have a look at this patch and provide feedback on moving Person from shindig to core. I was planning to fix the tests once consensus was achieved. I'll have a look at RAVE-524 to see how it impacts this patch.
Regards,
Richard
> Move Person repository from rave-shindig to rave-core
> ------------------------------------------------------
>
> Key: RAVE-509
> URL: https://issues.apache.org/jira/browse/RAVE-509
> Project: Rave
> Issue Type: Improvement
> Components: rave-core, rave-shindig
> Affects Versions: 0.8-INCUBATING
> Reporter: Richard Kettelerij
> Priority: Critical
> Fix For: 0.10-INCUBATING
>
> Attachments: rave_jpa_refactoring_trunk.patch
>
>
> I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server (*).
> Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
> With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.
> (*) With OpenJPA as the persistence provider, no Hibernate involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira