You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "prabhusneha (via GitHub)" <gi...@apache.org> on 2025/04/19 11:08:29 UTC
[PR] Remove duplicate 'mock_supervisor_comms' pytest fixture definitions [airflow]
prabhusneha opened a new pull request, #49457:
URL: https://github.com/apache/airflow/pull/49457
Removing the `mock_supervisor_comms` pytest fixure from -
`airflow-core/tests/unit/hooks/test_base.py`
`airflow-core/tests/unit/models/test_taskinstance.py`
as it is already defined in `airflow-core/tests/conftest.py`
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove duplicate 'mock_supervisor_comms' pytest fixture definitions [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #49457:
URL: https://github.com/apache/airflow/pull/49457#issuecomment-2819125473
> @amoghrajesh These are the locations where `mock_supervisor_comms` is defined currently in main.
>
> 1. airflow-core/tests/conftest.py
> 2. airflow-core/tests/unit/hooks/test_base.py
> 3. airflow-core/tests/unit/models/test_taskinstance.py
> 4. devel-common/src/tests_common/pytest_plugin.py
> 5. providers/openlineage/tests/unit/openlineage/plugins/test_listener.py
>
> I had initially retained it in 1, so it can be removed from 2 and 3. Where are you suggesting it be moved for 4 and 5 as well?
If we have it in the pytest_plugin.py, it means it can be accessed from anywhere in the codebase. So you should be able to remove every other occurence. For the providers, make a different PR, rest can be in this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove duplicate 'mock_supervisor_comms' pytest fixture definitions [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49457:
URL: https://github.com/apache/airflow/pull/49457#issuecomment-2995779009
### Backport successfully created: v3-0-test
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-0-test</td>
<td><a href="https://github.com/apache/airflow/pull/52080"><img src="https://img.shields.io/badge/PR-52080-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove duplicate 'mock_supervisor_comms' pytest fixture definitions [airflow]
Posted by "prabhusneha (via GitHub)" <gi...@apache.org>.
prabhusneha commented on PR #49457:
URL: https://github.com/apache/airflow/pull/49457#issuecomment-2818449242
@amoghrajesh These are the locations where `mock_supervisor_comms` is defined currently in main.
1. airflow-core/tests/conftest.py
2. airflow-core/tests/unit/hooks/test_base.py
3. airflow-core/tests/unit/models/test_taskinstance.py
4. devel-common/src/tests_common/pytest_plugin.py
5. providers/openlineage/tests/unit/openlineage/plugins/test_listener.py
I had initially retained it in 1, so it can be removed from 2 and 3.
Where are you suggesting it be moved for 4 and 5 as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove duplicate 'mock_supervisor_comms' pytest fixture definitions [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #49457:
URL: https://github.com/apache/airflow/pull/49457#discussion_r2052307116
##########
conftest.py:
##########
@@ -0,0 +1,30 @@
+#!/usr/bin/env python3
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from unittest import mock
+
+import pytest
+
+
+@pytest.fixture
+def mock_supervisor_comms():
+ with mock.patch(
+ "airflow.sdk.execution_time.task_runner.SUPERVISOR_COMMS", create=True
+ ) as supervisor_comms:
+ yield supervisor_comms
Review Comment:
Why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove duplicate 'mock_supervisor_comms' pytest fixture definitions [airflow]
Posted by "prabhusneha (via GitHub)" <gi...@apache.org>.
prabhusneha commented on code in PR #49457:
URL: https://github.com/apache/airflow/pull/49457#discussion_r2052440392
##########
conftest.py:
##########
@@ -0,0 +1,30 @@
+#!/usr/bin/env python3
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from unittest import mock
+
+import pytest
+
+
+@pytest.fixture
+def mock_supervisor_comms():
+ with mock.patch(
+ "airflow.sdk.execution_time.task_runner.SUPERVISOR_COMMS", create=True
+ ) as supervisor_comms:
+ yield supervisor_comms
Review Comment:
Please ignore. Was trying to add conftest at the root
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove duplicate 'mock_supervisor_comms' pytest fixture definitions [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #49457:
URL: https://github.com/apache/airflow/pull/49457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org