You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/12/13 22:46:33 UTC

[GitHub] [phoenix] yanxinyi commented on a change in pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table

yanxinyi commented on a change in pull request #1363:
URL: https://github.com/apache/phoenix/pull/1363#discussion_r768181236



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -4354,6 +4360,18 @@ private PhoenixConnection upgradeSystemTask(
         return metaConnection;
     }
 
+    private PhoenixConnection upgradeSystemTransform(
+            PhoenixConnection metaConnection,
+            Map<String, String> systemTableToSnapshotMap)
+            throws SQLException {
+        try (Statement statement = metaConnection.createStatement()) {
+            statement.executeUpdate(getTransformDDL());
+        } catch (TableAlreadyExistsException ignored) {
+

Review comment:
       nit: better to add logging here so that we know the creation of the table is failed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org