You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/08/17 04:46:55 UTC
[GitHub] [incubator-brpc] zengshicai2015 opened a new issue, #1891: 如何关闭 sampler 线程？
zengshicai2015 opened a new issue, #1891:
URL: https://github.com/apache/incubator-brpc/issues/1891
当前在我们线上场景发现bvar 线程始终是100%在运转的。所以我们在思考，
1，能否彻底关闭bvar 的sampler 线程？从代码来看，当前貌似没有关闭的gflag。
2，关闭了sampler 线程对brpc实际的影响是啥？仅仅是一些统计值看不了吗？如果我们不关心这些统计值的话，是不是就没有影响？
3，能否在后续的迭代版本中增加一个gflag，用来控制是否开启sampler线程？
辛苦帮忙解答一下，谢谢，Thanks♪(･ω･)ﾉ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen closed issue #1891: 如何关闭 sampler 线程？
Posted by GitBox <gi...@apache.org>.
serverglen closed issue #1891: 如何关闭 sampler 线程？
URL: https://github.com/apache/incubator-brpc/issues/1891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on issue #1891: 如何关闭 sampler 线程？
Posted by GitBox <gi...@apache.org>.
serverglen commented on issue #1891:
URL: https://github.com/apache/incubator-brpc/issues/1891#issuecomment-1313379378
已合入，closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] serverglen commented on issue #1891: 如何关闭 sampler 线程？
Posted by GitBox <gi...@apache.org>.
serverglen commented on issue #1891:
URL: https://github.com/apache/incubator-brpc/issues/1891#issuecomment-1219146057
1. 目前确实没有关闭 sampler的 gflag
2. 关闭 sampler 线程 会导致 所有的bvar统计值失效，我理解应该不影响brpc和用户的业务逻辑
3. 可以增加一个gflag控制是否开启sampler线程。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] leaf-potato commented on issue #1891: 如何关闭 sampler 线程？
Posted by GitBox <gi...@apache.org>.
leaf-potato commented on issue #1891:
URL: https://github.com/apache/incubator-brpc/issues/1891#issuecomment-1312703844
PR: #1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org