[GitHub] lvfen commented on a change in pull request #1969: [Android]fix setInstanceViewPort not effect native viewPort

[GitBox <gi...@apache.org>]

lvfen commented on a change in pull request #1969: [Android]fix setInstanceViewPort not effect native viewPort
URL: https://github.com/apache/incubator-weex/pull/1969#discussion_r244446253
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
 ##########
 @@ -453,6 +453,10 @@ public void restart() {
     mWXBridge.resetWXBridge(WXEnvironment.sRemoteDebugMode);
   }
 
+  public void recordViewPort(String instanceId, float viewPort) {
+    mWXBridge.recordViewPort(instanceId, viewPort);
 
 Review comment:
   setViewPortWidth call only when page is create, but sometimes we can create a wxSdkInstance but has not render, so that the page is not create, when we call setViewPortWidth is invalid, anymore setViewPortWidth in C++ will be call by RenderManager, wo we can not record view port width on SetViewPortWidth

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services