You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "PakhomovAlexander (via GitHub)" <gi...@apache.org> on 2023/09/05 15:58:39 UTC
[GitHub] [ignite-3] PakhomovAlexander opened a new pull request, #2553: IGNITE-20351 Log response body in REST test if it fails
PakhomovAlexander opened a new pull request, #2553:
URL: https://github.com/apache/ignite-3/pull/2553
* Also, get rid of parallel start/stop nodes
https://issues.apache.org/jira/browse/IGNITE-20351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander merged pull request #2553: IGNITE-20351 Log response body in REST test if it fails
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander merged PR #2553:
URL: https://github.com/apache/ignite-3/pull/2553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #2553: IGNITE-20351 Log response body in REST test if it fails
Posted by "Flaugh24 (via GitHub)" <gi...@apache.org>.
Flaugh24 commented on code in PR #2553:
URL: https://github.com/apache/ignite-3/pull/2553#discussion_r1316863103
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -82,7 +82,7 @@ void setUp(TestInfo testInfo) {
})
.collect(toList());
- nodes.stream().parallel().forEach(RestNode::start);
Review Comment:
I still don't understand why using parallel mode in this context is incorrect. If tests are failing because they interact with the REST API when the node isn't ready, that issue should be fixed in another way. By avoiding parallel mode, you're only increasing the time it takes to run these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #2553: IGNITE-20351 Log response body in REST test if it fails
Posted by "Flaugh24 (via GitHub)" <gi...@apache.org>.
Flaugh24 commented on code in PR #2553:
URL: https://github.com/apache/ignite-3/pull/2553#discussion_r1316864718
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -82,7 +82,7 @@ void setUp(TestInfo testInfo) {
})
.collect(toList());
- nodes.stream().parallel().forEach(RestNode::start);
Review Comment:
Moreover, it doesn't fix the issue at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2553: IGNITE-20351 Log response body in REST test if it fails
Posted by "PakhomovAlexander (via GitHub)" <gi...@apache.org>.
PakhomovAlexander commented on code in PR #2553:
URL: https://github.com/apache/ignite-3/pull/2553#discussion_r1316985727
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/rest/authentication/ItAuthenticationTest.java:
##########
@@ -82,7 +82,7 @@ void setUp(TestInfo testInfo) {
})
.collect(toList());
- nodes.stream().parallel().forEach(RestNode::start);
Review Comment:
I am open to ideas on how the issue can be found and fixed. Contributions are welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org