You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/12/24 09:31:47 UTC
Review Request 55022: Windows: Cause errors to be correctly reported
in `io::read`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Cause errors to be correctly reported in `io::read`.
Diffs
-----
3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
Diff: https://reviews.apache.org/r/55022/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55022: Windows: Cause errors to be correctly
reported in `io::read`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/#review161996
-----------------------------------------------------------
Ship it!
I plan to update the commit summary to:
```
Windows: Fixed error messages in `io::read/write`.
```
- Joseph Wu
On Jan. 15, 2017, 2:23 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55022/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2017, 2:23 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Cause errors to be correctly reported in `io::read`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp c37ec1811fab7d8d33f0d5fd8703ab121d6db514
>
> Diff: https://reviews.apache.org/r/55022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55022: Windows: Cause errors to be correctly
reported in `io::read`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/
-----------------------------------------------------------
(Updated Jan. 15, 2017, 10:23 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
Changes
-------
Rebased, addressed Joseph's comments.
Repository: mesos
Description
-------
Windows: Cause errors to be correctly reported in `io::read`.
Diffs (updated)
-----
3rdparty/libprocess/src/io.cpp c37ec1811fab7d8d33f0d5fd8703ab121d6db514
Diff: https://reviews.apache.org/r/55022/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55022: Windows: Cause errors to be correctly
reported in `io::read`.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Jan. 10, 2017, 6:09 p.m., Joseph Wu wrote:
> > The change LGTM, but it might need a rebase due to some changes BenH made to the same file. And MPark will also be committing a change to this file soon (related to `io::peek`).
> >
> > A few things to note:
> >
> > * Why not make the same changes to `io::write`?
> > * Remove the TODO that BenH left: `TODO(benh): Confirm that `os::strerror` does the right thing for `error` on Windows.`
Note: the `io::peek` review has been committed, so a rebase will be especially useful now.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/#review161170
-----------------------------------------------------------
On Dec. 24, 2016, 1:31 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55022/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 1:31 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Cause errors to be correctly reported in `io::read`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
>
> Diff: https://reviews.apache.org/r/55022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55022: Windows: Cause errors to be correctly
reported in `io::read`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Jan. 11, 2017, 2:09 a.m., Joseph Wu wrote:
> > The change LGTM, but it might need a rebase due to some changes BenH made to the same file. And MPark will also be committing a change to this file soon (related to `io::peek`).
> >
> > A few things to note:
> >
> > * Why not make the same changes to `io::write`?
> > * Remove the TODO that BenH left: `TODO(benh): Confirm that `os::strerror` does the right thing for `error` on Windows.`
>
> Joseph Wu wrote:
> Note: the `io::peek` review has been committed, so a rebase will be especially useful now.
I'll do it tonight.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/#review161170
-----------------------------------------------------------
On Dec. 24, 2016, 9:31 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55022/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 9:31 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Cause errors to be correctly reported in `io::read`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
>
> Diff: https://reviews.apache.org/r/55022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 55022: Windows: Cause errors to be correctly
reported in `io::read`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55022/#review161170
-----------------------------------------------------------
The change LGTM, but it might need a rebase due to some changes BenH made to the same file. And MPark will also be committing a change to this file soon (related to `io::peek`).
A few things to note:
* Why not make the same changes to `io::write`?
* Remove the TODO that BenH left: `TODO(benh): Confirm that `os::strerror` does the right thing for `error` on Windows.`
- Joseph Wu
On Dec. 24, 2016, 1:31 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55022/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 1:31 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Cause errors to be correctly reported in `io::read`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/io.cpp 27da897894e12941a6bba5f5eda04c35100d2d73
>
> Diff: https://reviews.apache.org/r/55022/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>