You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/09 06:10:11 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #34839: [SPARK-37569][SQL] Don't mark nested view fields as nullable

cloud-fan commented on a change in pull request #34839:
URL: https://github.com/apache/spark/pull/34839#discussion_r765458265



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -903,4 +903,16 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
       }
     }
   }
+
+  test("SPARK-37569: view should report correct nullability information for nested fields") {

Review comment:
       can we move the test to `SQLViewTestSuite`? so that we can test it with temp, global temp and permanent views.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org