You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2026/06/08 19:22:55 UTC
[I] Simplify translation files by using nesting [airflow]
bbovenzi opened a new issue, #68252:
URL: https://github.com/apache/airflow/issues/68252
Problem:
We repeat a lot of our translation keys. This makes an ever larger surface area to maintain for every language. It can also introduce room for inconsistencies in how the same phrase is translated.
Solution:
Use nesting ([docs](https://www.i18next.com/translation-function/nesting)) to reuse many of our keys.
One point to consider is making sure we can refer to translations in separate json files so that we can keep base concepts in `common.json`. But even starting with nesting translation keys inside of a single file would make our code much more DRY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Simplify translation files by using nesting [airflow]
Posted by "tanusattri (via GitHub)" <gi...@apache.org>.
tanusattri commented on issue #68252:
URL: https://github.com/apache/airflow/issues/68252#issuecomment-4652671381
Hi! I would love to work on this issue. Making the translation keys DRY using a nested structure and separating base concepts into a centralized file sounds like a great cleanup. Could you please assign this to me, and point me toward where the primary translation JSON files are located in the project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Simplify translation files by using nesting [airflow]
Posted by "pranampagi (via GitHub)" <gi...@apache.org>.
pranampagi commented on issue #68252:
URL: https://github.com/apache/airflow/issues/68252#issuecomment-4659434457
Hi @tanusattri I was actually just looking into this too and I have a local fix ready using nested keys in common.json. Are you already actively working on a PR for this? If you haven't started yet, I'd be happy to push my branch up—but I don't want to step on your toes if you're already on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Simplify translation files by using nesting [airflow]
Posted by "tanusattri (via GitHub)" <gi...@apache.org>.
tanusattri commented on issue #68252:
URL: https://github.com/apache/airflow/issues/68252#issuecomment-4666634938
Hey! Thanks for checking in. You can absolutely go ahead and push your
branch. I was tied up with something else and haven't started working on a
PR for this yet. Appreciate you taking a look at it!
On Tue, 9 Jun, 2026, 5:22 pm Pranam Pagi, ***@***.***> wrote:
> *pranampagi* left a comment (apache/airflow#68252)
> <https://github.com/apache/airflow/issues/68252#issuecomment-4659434457>
>
> Hi @tanusattri <https://github.com/tanusattri> I was actually just
> looking into this too and I have a local fix ready using nested keys in
> common.json. Are you already actively working on a PR for this? If you
> haven't started yet, I'd be happy to push my branch up—but I don't want to
> step on your toes if you're already on it!
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/issues/68252?email_source=notifications&email_token=BMA5OHYDBUL36RUUZWMOEFL4673AFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRVHE2DGNBUGU32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4659434457>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BMA5OHYNXZNMOG2QZZGMPZT4673AFAVCNFSM6AAAAACZ7TRD6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMNJZGQZTINBVG4>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/BMA5OH5ZD7TAL3YJOLN2MRL4673AFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRVHE2DGNBUGU32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/BMA5OHZ4G7QYEPTC2OX4XIL4673AFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRVHE2DGNBUGU32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Simplify translation files by using nesting [airflow]
Posted by "venkatamandavilli-code (via GitHub)" <gi...@apache.org>.
venkatamandavilli-code commented on issue #68252:
URL: https://github.com/apache/airflow/issues/68252#issuecomment-4732346787
Thanks for reporting this and for identifying the behavior around `logical_date`.
Based on the reproduction steps, it appears that the DAG definition itself remains unchanged, but a dynamic value associated with `TriggerDagRunOperator` may be influencing the serialized representation used for DAG version calculation.
From an operational perspective, DAG versions are most useful when they reflect meaningful changes to the DAG structure or configuration. If a runtime-generated value causes the version to increment on every execution, it becomes more difficult to use version history for deployment tracking, auditing, and troubleshooting.
The fact that the behavior disappears when `logical_date=None` is specified seems like an important clue. It may be worth reviewing whether the operator's default logical date handling introduces a value that changes between parses and whether that value should participate in DAG serialization or version comparison.
This seems particularly relevant for environments that make extensive use of `TriggerDagRunOperator` and rely on DAG version history to understand when actual workflow definitions have changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Simplify translation files by using nesting [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 closed issue #68252: Simplify translation files by using nesting
URL: https://github.com/apache/airflow/issues/68252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org