[GitHub] [arrow-rs] jorgecarleitao commented on a change in pull request #453: Add C data interface for decimal128 and timestamp

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #453:
URL: https://github.com/apache/arrow-rs/pull/453#discussion_r656113144



##########
File path: arrow/src/ffi.rs
##########
@@ -271,12 +271,54 @@ fn to_field(schema: &FFI_ArrowSchema) -> Result<Field> {
                 .collect::<Result<Vec<_>>>()?;
             DataType::Struct(children)
         }
-        other => {
-            return Err(ArrowError::CDataInterface(format!(
-                "The datatype \"{:?}\" is still not supported in Rust implementation",
-                other
-            )))
-        }
+        other => match other
+            .split(|c| c == ':' || c == ',')

Review comment:
       If we allow this, we open the door to allow variations of the spec in order to be robust. imo this makes the spec weaker: producers can "get away" with variations of the spec when using Rust, but will fail in e.g. C++. imo this defeats the purpose of a spec and the Arrow project, as interoperability is not no longer guaranteed.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org