You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/03/10 03:41:02 UTC
[PR] [SPARK-55911] Improve `ModelUtils` to support `isClientMode` method [spark-kubernetes-operator]
dongjoon-hyun opened a new pull request, #544:
URL: https://github.com/apache/spark-kubernetes-operator/pull/544
### What changes were proposed in this pull request?
This PR adds `ModelUtils.isClientMode` utility method and uses it in `AppValidateStep` to improve code readability.
### Why are the changes needed?
The inline deployment mode check `ClientMode == context.getResource().getSpec().getDeploymentMode()` is verbose and may be needed in multiple places. Extracting it into a reusable `isClientMode` utility method in `ModelUtils` improves readability and consistency, following the same pattern as `isValidApplicationStatus` in `SparkAppStatusUtils`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
A new unit test `testIsClientMode` was added in `ModelUtilsTest` to verify both `ClientMode` and `ClusterMode` cases.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55911] Improve `ModelUtils` to support `isClientMode` method [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #544:
URL: https://github.com/apache/spark-kubernetes-operator/pull/544#issuecomment-4028652220
Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55911] Improve `ModelUtils` to support `isClientMode` method [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #544:
URL: https://github.com/apache/spark-kubernetes-operator/pull/544#issuecomment-4032686323
Thank you, @peter-toth .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55911] Improve `ModelUtils` to support `isClientMode` method [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #544: [SPARK-55911] Improve `ModelUtils` to support `isClientMode` method
URL: https://github.com/apache/spark-kubernetes-operator/pull/544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55911] Improve `ModelUtils` to support `isClientMode` method [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #544:
URL: https://github.com/apache/spark-kubernetes-operator/pull/544#issuecomment-4028654215
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org