You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by "Jürgen Hoffmann (JIRA)" <ji...@apache.org> on 2006/06/22 15:42:30 UTC

[jira] Commented: (TRB-9) Intake: Handling of empty values

    [ http://issues.apache.org/jira/browse/TRB-9?page=comments#action_12417306 ] 

Jürgen Hoffmann commented on TRB-9:
-----------------------------------

This patch also addresses the issue of intake, not being able to use default validators i.e. BooleanValidator, if the rules are empty.

> Intake: Handling of empty values
> --------------------------------
>
>          Key: TRB-9
>          URL: http://issues.apache.org/jira/browse/TRB-9
>      Project: Turbine
>         Type: Bug

>   Components: Turbine 2.3
>     Versions: Core 2.3.2
>     Reporter: Stefan Broetz
>     Priority: Blocker
>  Attachments: patch_TRB-9.txt
>
> It seems to be impossible transmit the empty string as a value: In the HTTP request
>   http://.../turbine/...?aaa=123&bbb=&ccc=456
> the parameter bbb is ignored.
> If you look at org.apache.turbine.services.intake.model.Field.init(ValueParser pp) you find:
>         if (pp.containsKey(getKey()))
>         {
>             if (isDebugEnabled)
>             {
>                 log.debug(name + ": Found our Key in the request, setting Value");
>             }
>             if (StringUtils.isNotEmpty(pp.getString(getKey())))
>             {
>                 setFlag = true;
>             }
>             validate();
>         }
>         else if (pp.containsKey(getValueIfAbsent()) &&
>                 pp.getString(getValueIfAbsent()) != null)
>         {
>             pp.add(getKey(), pp.getString(getValueIfAbsent()));
>             setFlag = true;
>             validate();
>         }
> The StringUtils.isNotEmpty() condition (line 342) prevents that a field can take up the empty string as its value.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org