Shutdown bug (was: Re: Releasing 2.1.1?)

[Jeff Turner <je...@apache.org>]

On Fri, Aug 29, 2003 at 10:18:40PM +0200, Bruno Dumon wrote:
...
[on bug http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18131]
...
> ok, 10 minutes later now, got an idea:
> 
> if you add the following code before the closing bracket of the
> PooledExecutor.workerDone(...) method, then it --seems to-- work:
> 
>     if (!shutdown_) {
>       if (poolSize_ < maximumPoolSize_) {
>         Runnable r= null;
>         try {
>           r = getTask();
>         } catch (InterruptedException e) {
>           e.printStackTrace();
>         }
>         if (r != null)
>           addThread(r);
>       }
>     }
> 
> Could someone else also try this out? For your convenience, here's a
> compiled jar with this change:
> http://outerthought.net/~bruno/concurrent.jar
> 
> just copy it over the util.concurrent-1.3.1.jar

Great :)  Tomcat shutdown works fine on my system with this jar.  Thanks
muchly.  


--Jeff

Re: Shutdown bug (was: Re: Releasing 2.1.1?)

[Antonio Gallardo <ag...@agsoftware.dnsalias.com>]

Jeff Turner dijo:
> On Fri, Aug 29, 2003 at 10:18:40PM +0200, Bruno Dumon wrote:
> ...
> [on bug http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18131]
> ...
>> ok, 10 minutes later now, got an idea:
>>
>> if you add the following code before the closing bracket of the
>> PooledExecutor.workerDone(...) method, then it --seems to-- work:
>>
>>     if (!shutdown_) {
>>       if (poolSize_ < maximumPoolSize_) {
>>         Runnable r= null;
>>         try {
>>           r = getTask();
>>         } catch (InterruptedException e) {
>>           e.printStackTrace();
>>         }
>>         if (r != null)
>>           addThread(r);
>>       }
>>     }
>>
>> Could someone else also try this out? For your convenience, here's a
>> compiled jar with this change:
>> http://outerthought.net/~bruno/concurrent.jar
>>
>> just copy it over the util.concurrent-1.3.1.jar
>
> Great :)  Tomcat shutdown works fine on my system with this jar.  Thanks
> muchly.

Brilliant Bruno! Where you will commit this long awaited feature and close
the bug. ;)

Best Regards,

Antonio Gallardo
>
>
> --Jeff