You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2021/01/08 19:28:42 UTC

Review Request 73125: RANGER-3122: Support delegate-admin for specific permissions - part 3

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73125/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-3122
    https://issues.apache.org/jira/browse/RANGER-3122


Repository: ranger


Description
-------

Currently delegate-admin cannot be marked for specific permissions. It is all-or-nothing for the permissions defined in resource policy. Ranger should have ability for granting delegate-admin for specific permissions.

This patch fixes the following issue:

If a service-admin fetches policies for the service, then the returned list contains multiple copies of the same policy.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 63ad28199 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java b67656e2e 


Diff: https://reviews.apache.org/r/73125/diff/1/


Testing
-------

Tested with service-admin user to retrieve policies using cURL. Ensured that the returned list contains only one copy of filtered policies.


Thanks,

Abhay Kulkarni


Re: Review Request 73125: RANGER-3122: Support delegate-admin for specific permissions - part 3

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73125/#review222422
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Jan. 8, 2021, 7:28 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73125/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2021, 7:28 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3122
>     https://issues.apache.org/jira/browse/RANGER-3122
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently delegate-admin cannot be marked for specific permissions. It is all-or-nothing for the permissions defined in resource policy. Ranger should have ability for granting delegate-admin for specific permissions.
> 
> This patch fixes the following issue:
> 
> If a service-admin fetches policies for the service, then the returned list contains multiple copies of the same policy.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 63ad28199 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java b67656e2e 
> 
> 
> Diff: https://reviews.apache.org/r/73125/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with service-admin user to retrieve policies using cURL. Ensured that the returned list contains only one copy of filtered policies.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>