You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Ruwann (via GitHub)" <gi...@apache.org> on 2023/07/23 10:29:19 UTC

[GitHub] [beam] Ruwann opened a new pull request, #27621: Remove unused `reverse` argument in SmallestPerKey

Ruwann opened a new pull request, #27621:
URL: https://github.com/apache/beam/pull/27621

   Remove unused `reverse` argument in the SmallestPerKey PTransform as it is a convenience Transform wrapping  `Top.PerKey`.
   
   Similarly, the `Smallest` variant also does not have a `reverse` argument.
   
   https://github.com/apache/beam/blob/cbe2e0f5ad5e45a7f6d380b1b1ac36d5dede8f54/sdks/python/apache_beam/transforms/combiners.py#L305
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Ruwann commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "Ruwann (via GitHub)" <gi...@apache.org>.
Ruwann commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1677229516

   Thanks for the feedback, I can update the PR to just add this in the docstring and keep the function signature the same for backwards compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1677208841

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @tvalentyn for label python.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AnandInguva commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1648251825

   Do you think it was kept to preserve backward compatibility? 
   
   Let's add a note in the changes.md if possible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Ruwann commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "Ruwann (via GitHub)" <gi...@apache.org>.
Ruwann commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1648471965

   I think it was a mistake when adding the `reverse` argument, based on the following commit: https://github.com/apache/beam/commit/866a09d6c5c4c1c3c39d3a1f2e7b4cb7ec319f6f#diff-c939f20e41fc848a26c5c8435fb348f118e81d9ced53dec490c1e5720a1be339L215
   
   I can add a note in changes.md, although I'm not sure where's the best place: in theory, it's a potentially breaking if anyone is calling that function with that argument (even though it doesn't do anything) but that feels a bit heavy for this change. Wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1646816863

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @AnandInguva for label python.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] codecov[bot] commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1646806636

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27621?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#27621](https://app.codecov.io/gh/apache/beam/pull/27621?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a87de39) into [master](https://app.codecov.io/gh/apache/beam/commit/cbe2e0f5ad5e45a7f6d380b1b1ac36d5dede8f54?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cbe2e0f) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #27621   +/-   ##
   =======================================
     Coverage   71.09%   71.09%           
   =======================================
     Files         859      859           
     Lines      104545   104545           
   =======================================
   + Hits        74323    74326    +3     
   + Misses      28664    28661    -3     
     Partials     1558     1558           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `80.28% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/27621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/transforms/combiners.py](https://app.codecov.io/gh/apache/beam/pull/27621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.43% <100.00%> (ø)` | |
   
   ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27621/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1671214422

   Reminder, please take a look at this pr: @AnandInguva 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1677713979

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AnandInguva commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1660226892

   I would leave it like this if it can be a breaking change. We also have a `use_fastavro` https://github.com/apache/beam/blob/ab93fb1988051baac6c3b9dd1031f4d68bd9a149/sdks/python/apache_beam/io/avroio.py#L141 which is not used anymore but it was not removed for backwards compatibility. May be add a deprecated warning for 2.50.0 and remove it in 2.51.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1660193947

   Reminder, please take a look at this pr: @AnandInguva 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn merged pull request #27621: Remove unused `reverse` argument in SmallestPerKey

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #27621:
URL: https://github.com/apache/beam/pull/27621


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org