You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/11 12:34:01 UTC

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11434: [Doc][k8s] externalZookeeper.zookeeperRoot cannot specify the root directory of zookeeper

github-actions[bot] commented on issue #11434:
URL: https://github.com/apache/dolphinscheduler/issues/11434#issuecomment-1211928677

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   When deploying DS in a k8s cluster using Helm, the root directory of zookeeper (built-in or external) cannot be specified through `zookeeper.zookeeperRoot` or `externalZookeeper.zookeeperRoot` described in `kubernetes.md`.
   
   <img width="1068" alt="截屏2022-08-11 20 10 24" src="https://user-images.githubusercontent.com/38122586/184130478-efda82b3-2ab6-4ebc-a382-98c81a948af7.png">
   
   In fact, `zookeeperRoot` is not referenced by any yaml file, and `_helpers.tpl` only builds `REGISTRY_TYPE` and `REGISTRY_ZOOKEEPER_CONNECT_STRING` as below:
   
   ```
   {{/*
   Create a registry environment variables.
   */}}
   {{- define "dolphinscheduler.registry.env_vars" -}}
   - name: REGISTRY_TYPE
     {{- if .Values.zookeeper.enabled }}
     value: "zookeeper"
     {{- else }}
     value: {{ .Values.externalRegistry.registryPluginName }}
     {{- end }}
   - name: REGISTRY_ZOOKEEPER_CONNECT_STRING
     {{- if .Values.zookeeper.enabled }}
     value: {{ template "dolphinscheduler.zookeeper.quorum" . }}
     {{- else }}
     value: {{ .Values.externalRegistry.registryServers }}
     {{- end }}
   {{- end -}}
   ```
   
   So, how can user specify the root directory of zookeeper while deploying DS in k8s?
   
   Any comments or suggestions are welcome.
   
   ### Documentation Links
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org