You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/16 04:31:34 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #13657: [FLINK-19669][coordination] PipelinedRegionSchedulingStrategy#init ResultPartitionType blocking check use isBlocking method
zhuzhurk commented on a change in pull request #13657:
URL: https://github.com/apache/flink/pull/13657#discussion_r506045078
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategyTest.java
##########
@@ -67,13 +69,18 @@ private void buildTopology() {
source = testingSchedulingTopology.addExecutionVertices().withParallelism(PARALLELISM).finish();
map = testingSchedulingTopology.addExecutionVertices().withParallelism(PARALLELISM).finish();
+ map2 = testingSchedulingTopology.addExecutionVertices().withParallelism(PARALLELISM).finish();
Review comment:
I prefer to not change the topology for existing tests and not change unrelated tests.
I think it's better to add a new case `testSchedulingTopologyWithPersistentBlockingEdges()` which initializes a `PipelinedRegionSchedulingStrategy` from a topology which contains `BLOCKING_PERSISTENT` results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org