[GitHub] PaulAngus commented on a change in pull request #2869: Fix some Marvin smoke tests

[GitBox <gi...@apache.org>]

PaulAngus commented on a change in pull request #2869: Fix some Marvin smoke tests
URL: https://github.com/apache/cloudstack/pull/2869#discussion_r221676036
 
 

 ##########
 File path: test/integration/smoke/test_hostha_kvm.py
 ##########
 @@ -274,9 +274,12 @@ def test_hostha_enable_ha_when_host_in_maintenance(self):
             Tests Enable HA when host is in Maintenance mode, should be Ineligible
         """
         self.logger.debug("Starting test_hostha_enable_ha_when_host_in_maintenance")
-
+        self.logger.debug("Pausing to wait for VMs to have finished starting")
+        time.sleep(300)
 
 Review comment:
   ideally yes.  BUT a. that's beyond my ability (this is the 2nd bit of python i've ever written) and b. Across the test infrastructure, there may be many VMs/VRs and there may be many hosts.  In our Trillian environment there are only 2 hosts by default, so there is a fifty/fifty chance that there was a VR on the host that was fenced and then recovered.
   In the end, even trying to cover all of the possibilities seemed excessive for the use case. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services