[GitHub] [airflow] potiuk commented on a diff in pull request #24576: doc: reload pods when using the same DAG tag

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #24576:
URL: https://github.com/apache/airflow/pull/24576#discussion_r902365555


##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -77,6 +77,12 @@ If you are deploying an image with a constant tag, you need to make sure that th
       --set images.airflow.repository=my-company/airflow \
       --set images.airflow.tag=8a0da78 \
       --set images.airflow.pullPolicy=Always
+      

Review Comment:
   I would add a message discouraging use of constant tag and add this description below as an example of problems you might get when you do.
   
   Using constant image tags and re-uploading them is an extremely bad practice for production. you are not supposed to do it because you are completely loosing any traceability of what happened. It's equivalent of randomly changing your code in production server without keeping it in any kind of source repository history. Basically i cannot imagine any scenario where it would be acceptable other than one-man-run-airflow for own personal usage for testing/development.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org