You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/04 14:55:57 UTC

[GitHub] [airflow] zclimes opened a new pull request #12809: Add 'headers' to template_fields in HttpSensor

zclimes opened a new pull request #12809:
URL: https://github.com/apache/airflow/pull/12809


   Adds `headers` to the `template_fields` member of the `HttpSensor` class to allow templating headers.
   
   closes: #12796
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #12809: Add 'headers' to template_fields in HttpSensor

Posted by GitBox <gi...@apache.org>.

kaxil merged pull request #12809:
URL: https://github.com/apache/airflow/pull/12809


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #12809:
URL: https://github.com/apache/airflow/pull/12809#issuecomment-738828661

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

Posted by GitBox <gi...@apache.org>.

eladkal commented on pull request #12809:
URL: https://github.com/apache/airflow/pull/12809#issuecomment-905815868


   > How does one know in which release of airflow this change has been deployed?
   > 
   > I'm on airflow 1.10.15 and it seems that `headers` is not included in `template_fields`.
   
   Probably because you are importing the sensor from `contrib` rather than from `providers`.
   insall https://pypi.org/project/apache-airflow-backport-providers-http/
   then import it as:
   `from airflow.providers.http.sensors.http import HttpSensor
   `
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] atorres-eqrx commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

Posted by GitBox <gi...@apache.org>.

atorres-eqrx commented on pull request #12809:
URL: https://github.com/apache/airflow/pull/12809#issuecomment-905808828


   How does one know in which release of airflow this change has been deployed?
   
   I'm on airflow 1.10.15 and it seems that `headers` is not included in `template_fields`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #12809:
URL: https://github.com/apache/airflow/pull/12809#issuecomment-739096196


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] atorres-eqrx commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

Posted by GitBox <gi...@apache.org>.

atorres-eqrx commented on pull request #12809:
URL: https://github.com/apache/airflow/pull/12809#issuecomment-905821908


   > > How does one know in which release of airflow this change has been deployed?
   > > I'm on airflow 1.10.15 and it seems that `headers` is not included in `template_fields`.
   > 
   > Probably because you are importing the sensor from `contrib` rather than from `providers`.
   > insall https://pypi.org/project/apache-airflow-backport-providers-http/
   > then import it as:
   > `from airflow.providers.http.sensors.http import HttpSensor `
   
   That did the trick. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org