Re: [PR] IGNITE-24588 Fixed client-side tuple serialization when the schema has field names containing non-standard characters. [ignite-3]

["xtern (via GitHub)" <gi...@apache.org>]

xtern commented on code in PR #5493:
URL: https://github.com/apache/ignite-3/pull/5493#discussion_r2014230025


##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueViewSimpleSchemaApiTest.java:
##########
@@ -60,28 +60,38 @@ public class ItKeyValueViewSimpleSchemaApiTest extends ItKeyValueViewApiBaseTest
     private static final String TABLE_NAME_NON_NULLABLE_VALUE = "test_non_nullable_value";
 
     @BeforeAll
-    public void createTable() {
-        createTable(TABLE_NAME_SIMPLE_TYPE, List.of(new Column("VAL", NativeTypes.INT64, true)));
-        createTable(TABLE_NAME_NON_NULLABLE_VALUE, List.of(new Column("VAL", NativeTypes.INT64, false)));
+    void createTable() {
+        List<TestTableDefinition> tables = new ArrayList<>();
+        Column[] nullableValue = {new Column("VAL", NativeTypes.INT64, true)};
+
+        tables.add(new TestTableDefinition(TABLE_NAME_SIMPLE_TYPE, DEFAULT_KEY, nullableValue, true));
+
+        tables.add(new TestTableDefinition(
+                TABLE_NAME_NON_NULLABLE_VALUE,
+                DEFAULT_KEY,
+                new Column[] {new Column("VAL", NativeTypes.INT64, false)},
+                true
+        ));
 
         for (NativeType type : SchemaTestUtils.ALL_TYPES) {
             String tableName = "T_" + type.spec().name();
+            Column[] values = {new Column("VAL", type, false)};
 
-            createTable(tableName, false,
-                    List.of(new Column("id", NativeTypes.INT64, false)),
-                    List.of(new Column("VAL", type, true)));
+            tables.add(new TestTableDefinition(tableName, DEFAULT_KEY, values));
         }
 
         // Validate all types are tested.
         Set<NativeTypeSpec> nativeTypes = EnumSet.allOf(NativeTypeSpec.class);
 
         assertEquals(nativeTypes,
                 SchemaTestUtils.ALL_TYPES.stream().map(NativeType::spec).collect(Collectors.toSet()));
+
+        createTables(tables);
     }
 
     @ParameterizedTest
     @MethodSource("testCases")
-    public void put(TestCase<Long, Long> testCase) {
+    void put(TestCase<Long, Long> testCase) {

Review Comment:
   Such changes were made to reduce the number of warnings in IDEA.
   ```
   Class 'TestCase<Long, Long>' is exposed outside its defined visibility scope
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org