You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/18 03:46:39 UTC

[GitHub] [helix] pkuwm commented on pull request #1526: Leverage zk paginated getChildren API for ZkClient to fetch a large number of children

pkuwm commented on pull request #1526:
URL: https://github.com/apache/helix/pull/1526#issuecomment-747849827


   This PR is ready to be merged, approved by @jiajunwang 
   
   If a node has many children and the packet length exceeds the network buffer limit, the ZkClient's getChildren operation will fail. There are some cases that users will expect to fetch all the children successfully. Pagination could be used to support this feature. It requires the native zk to have the paginated getChildren API.
   
   This uses reflection to determine whether or not getChildren should use the native zk pagination api.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org