You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/12/31 14:50:15 UTC
[GitHub] [commons-lang] garydgregory opened a new pull request #483:
[LANG-1509] Add ObjectToStringComparator.
garydgregory opened a new pull request #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #483: [LANG-1509]
Add ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-570052765
> `.compare` sounds good to me. Couple of checkstyle issues in Travis now @garydgregory
>
> 
Oops, cleaned up now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] kinow commented on issue #483: [LANG-1509] Add
ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
kinow commented on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-570027944
`.compare` sounds good to me. Couple of checkstyle issues in Travis now @garydgregory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory edited a comment on issue #483:
[LANG-1509] Add ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-570052765
> `.compare` sounds good to me. Couple of checkstyle issues in Travis now @garydgregory
>
> 
Oops, cleaned up now. Waiting for GH checks...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #483: [LANG-1509]
Add ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-570023898
@kinow I moved it to `...compare` and I moved the new for 3.10 `ComparableUtils` there in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #483: [LANG-1509]
Add ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-569940488
Should it be Serializable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory commented on issue #483: [LANG-1509]
Add ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-570002958
@kinow I like the idea of putting it in a new package. What would you call it? "...compare"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] coveralls edited a comment on issue #483:
[LANG-1509] Add ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-569942524
[](https://coveralls.io/builds/27870422)
Coverage increased (+0.005%) to 95.085% when pulling **1a7042a96b619e7f28681366c34d5907d61f46be on garydgregory:LANG-1509_Add_ObjectToStringComparator** into **6f358e9e8d4a1be135d423f8a25262a2f3325463 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] garydgregory merged pull request #483: [LANG-1509]
Add ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-lang] coveralls commented on issue #483: [LANG-1509] Add
ObjectToStringComparator.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #483: [LANG-1509] Add ObjectToStringComparator.
URL: https://github.com/apache/commons-lang/pull/483#issuecomment-569942524
[](https://coveralls.io/builds/27860636)
Coverage decreased (-0.02%) to 95.062% when pulling **79a8010b2ae81e7e307ace2f1baa29cea08da722 on garydgregory:LANG-1509_Add_ObjectToStringComparator** into **1dcf141f7c79c3be9cf0157e811f775ae9f68270 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services