You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xianjingfeng (via GitHub)" <gi...@apache.org> on 2023/02/28 01:57:41 UTC

[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #663: [#80][Part-2] feat: Add RPC logic and heartbeat logic for decommisson

xianjingfeng commented on code in PR #663:
URL: https://github.com/apache/incubator-uniffle/pull/663#discussion_r1119497554


##########
proto/src/main/proto/Rss.proto:
##########
@@ -234,6 +234,13 @@ message ShuffleCommitResponse {
   string retMsg = 3;
 }
 
+enum ServerStatus {
+  ACTIVE = 0;

Review Comment:
   Protobuf has a default value named UNRECOGNIZED



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org