You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by aprooks <gi...@git.apache.org> on 2014/04/09 12:15:30 UTC
[GitHub] incubator-storm pull request: storm-starter Readme: Main class par...
GitHub user aprooks opened a pull request:
https://github.com/apache/incubator-storm/pull/64
storm-starter Readme: Main class param should be quoted
In windows, maven throws exception if mainclass parameter is not quoted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aprooks/incubator-storm patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 1e23111f925d62f4f14e66293780ab3832f5165d
Author: aprooks <al...@gmail.com>
Date: 2014-04-09T10:12:34Z
Main class param should be quoted
In windows, maven throws exception if mainclass parameter is not quoted
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-309] storm-starter Readme: Ma...
Posted by aprooks <gi...@git.apache.org>.
Github user aprooks commented on the pull request:
https://github.com/apache/incubator-storm/pull/64#issuecomment-42330538
@revans2 done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-309 storm-starter Readme: Main...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/64#issuecomment-42332408
Thanks, +1 for this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-309 storm-starter Readme: Main...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/64#issuecomment-43674246
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: storm-starter Readme: Main class par...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/64#issuecomment-42324845
Could you please file a JIRA for this and put the JIRA number in the pull request title. I am +1 for the change, but we need to track it properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-309 storm-starter Readme: Main...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---