You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2018/01/22 20:26:07 UTC
hbase git commit: HBASE-19840 Flakey TestMetaWithReplicas
Repository: hbase
Updated Branches:
refs/heads/branch-2 0fa24dddb -> 1e5fc1ed6
HBASE-19840 Flakey TestMetaWithReplicas
Adding debuging
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1e5fc1ed
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1e5fc1ed
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1e5fc1ed
Branch: refs/heads/branch-2
Commit: 1e5fc1ed63039390ecd5d3a45c96232338e7ae83
Parents: 0fa24dd
Author: Michael Stack <st...@apache.org>
Authored: Mon Jan 22 12:24:52 2018 -0800
Committer: Michael Stack <st...@apache.org>
Committed: Mon Jan 22 12:26:03 2018 -0800
----------------------------------------------------------------------
.../hadoop/hbase/client/TestMetaWithReplicas.java | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/1e5fc1ed/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java
index e01c28f..7099408 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaWithReplicas.java
@@ -30,6 +30,8 @@ import java.util.Collection;
import java.util.EnumSet;
import java.util.List;
import java.util.concurrent.ExecutorService;
+import java.util.concurrent.atomic.AtomicBoolean;
+
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.Abortable;
import org.apache.hadoop.hbase.CategoryBasedTimeout;
@@ -93,14 +95,14 @@ public class TestMetaWithReplicas {
// disable the balancer
LoadBalancerTracker l = new LoadBalancerTracker(TEST_UTIL.getZooKeeperWatcher(),
new Abortable() {
- boolean aborted = false;
+ AtomicBoolean aborted = new AtomicBoolean(false);
@Override
public boolean isAborted() {
- return aborted;
+ return aborted.get();
}
@Override
public void abort(String why, Throwable e) {
- aborted = true;
+ aborted.set(true);
}
});
l.setBalancerOn(false);
@@ -174,6 +176,7 @@ public class TestMetaWithReplicas {
conf.get("zookeeper.znode.metaserver", "meta-region-server"));
byte[] data = ZKUtil.getData(zkw, primaryMetaZnode);
ServerName primary = ProtobufUtil.toServerName(data);
+ LOG.info("Primary=" + primary.toString());
TableName TABLE = TableName.valueOf("testShutdownHandling");
byte[][] FAMILIES = new byte[][] { Bytes.toBytes("foo") };
@@ -208,14 +211,17 @@ public class TestMetaWithReplicas {
master = util.getHBaseClusterInterface().getClusterMetrics().getMasterName();
// kill the master so that regionserver recovery is not triggered at all
// for the meta server
+ LOG.info("Stopping master=" + master.toString());
util.getHBaseClusterInterface().stopMaster(master);
util.getHBaseClusterInterface().waitForMasterToStop(master, 60000);
+ LOG.info("Master stopped!");
if (!master.equals(primary)) {
util.getHBaseClusterInterface().killRegionServer(primary);
util.getHBaseClusterInterface().waitForRegionServerToStop(primary, 60000);
}
((ClusterConnection)c).clearRegionCache();
}
+ LOG.info("Running GETs");
Get get = null;
Result r = null;
byte[] row = "test".getBytes();
@@ -231,12 +237,15 @@ public class TestMetaWithReplicas {
assertTrue(Arrays.equals(r.getRow(), row));
// now start back the killed servers and disable use of replicas. That would mean
// calls go to the primary
+ LOG.info("Starting Master");
util.getHBaseClusterInterface().startMaster(master.getHostname(), 0);
util.getHBaseClusterInterface().startRegionServer(primary.getHostname(), 0);
util.getHBaseClusterInterface().waitForActiveAndReadyMaster();
+ LOG.info("Master active!");
((ClusterConnection)c).clearRegionCache();
}
conf.setBoolean(HConstants.USE_META_REPLICAS, false);
+ LOG.info("Running GETs no replicas");
try (Table htable = c.getTable(TABLE);) {
r = htable.get(get);
assertTrue(Arrays.equals(r.getRow(), row));