You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by arings <gi...@git.apache.org> on 2018/07/15 18:02:06 UTC

[GitHub] tinkerpop pull request #890: Expose Pick in module.exports

GitHub user arings opened a pull request:

    https://github.com/apache/tinkerpop/pull/890

    Expose Pick in module.exports

    #460 so `Pick.any` and `Pick.none` can be used in gremlin-javascript.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arings/tinkerpop TINKERPOP-1507-JS

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #890
    
----
commit 60267bf773f7d460f13fa6f82a2bf38578aefae9
Author: arings <ar...@...>
Date:   2018-07-15T17:51:08Z

    Expose pick object in module.exports

----


---

[GitHub] tinkerpop issue #890: Expose Pick in module.exports

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/890
  
    `Pick` is covered by the cucumber tests and those features are passing: https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L190
    
    The problem is that we weren't exporting `pick` enum for users to access it.


---

[GitHub] tinkerpop issue #890: Expose Pick in module.exports

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/890
  
    @jorgebay any reason this wasnt noted in GLV tests? are we missing a scenario?


---

[GitHub] tinkerpop issue #890: Expose Pick in module.exports

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/890
  
    Looks good, thanks @arings !
    
    VOTE: +1
    
    I've filed a ticket to keep track of this bug fix: TINKERPOP-2009.
    
    Committers: note that we should merge it to `tp32`.


---

[GitHub] tinkerpop pull request #890: Expose Pick in module.exports

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/890


---

[GitHub] tinkerpop issue #890: Expose Pick in module.exports

Posted by jorgebay <gi...@git.apache.org>.

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/890
  
    Cherry picked and landed in c324002c7d2184b87ef1e90067c318ebf727311f (`tp32`, `tp33` and `master`).
    
    Thanks @arings!


---

[GitHub] tinkerpop issue #890: Expose Pick in module.exports

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/890
  
    VOTE +1


---