You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/01/06 09:51:54 UTC
[GitHub] [trafficserver] hejcz commented on a change in pull request #8579: Fixes compacting spaces in S3 auth plugin
hejcz commented on a change in pull request #8579:
URL: https://github.com/apache/trafficserver/pull/8579#discussion_r779425447
##########
File path: plugins/s3_auth/aws_auth_v4.cc
##########
@@ -192,8 +192,22 @@ trimWhiteSpaces(const char *in, size_t inLen, size_t &newLen)
last--;
}
- newLen = last - first + 1;
- return first;
+ std::stringstream result;
+ int consecutiveSpaces = 0;
+ while (first <= last) {
+ if (*first == ' ') {
Review comment:
You're right. I didn't read that issue carefully. I opened a new issue describing what I'm actually trying to fix https://github.com/apache/trafficserver/issues/8583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org