You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2017/06/28 07:36:16 UTC
[GitHub] cordova-lib pull request #572: CB-6143: Change plugman.emit() to events.emit...
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-lib/pull/572
CB-6143: Change plugman.emit() to events.emit()
### Platforms affected
all
### What does this PR do?
https://issues.apache.org/jira/browse/CB-6143
Changes remaining `plugman.emit()` calls to `events.emit()` for consistency and to fix a build error when building a browserified app.
### What testing has been done on this change?
`npm test`, built an android app, built a browserified android app
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-lib CB-6143
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #572
----
commit e32371e767bd43a86d0f83201b1d473891525fb4
Author: Alexander Sorokin <al...@akvelon.com>
Date: 2017-06-28T07:28:58Z
CB-6143: Change plugman.emit() to events.emit()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #572: CB-6143: Change plugman.emit() to events.emit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #572: CB-6143: Change plugman.emit() to events.emit()
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/572
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=h1) Report
> Merging [#572](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/d6fcbc3719e72085be75b03d68cec1bc7e5c162c?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 43.06% 43.06%
=======================================
Files 78 78
Lines 4361 4361
Branches 852 852
=======================================
Hits 1878 1878
Misses 2483 2483
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/plugman/browserify.js](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vYnJvd3NlcmlmeS5qcw==) | `8.33% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=footer). Last update [d6fcbc3...e32371e](https://codecov.io/gh/apache/cordova-lib/pull/572?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org