You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/03/27 04:24:35 UTC
Review Request 19710: AURORA-78: automate and enforce release workflow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/
-----------------------------------------------------------
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-78
https://issues.apache.org/jira/browse/AURORA-78
Repository: aurora
Description
-------
AURORA-78: automate and enforce release workflow
Adds scripts to generate the CHANGELOG from JIRA, create the
release candidate, generate the release candidate VOTE email draft,
generate the release from the release candidate and the RESULT VOTE
email draft. docs/committers.md added with process flow details.
Diffs
-----
CHANGELOG PRE-CREATION
build-support/release/changelog PRE-CREATION
build-support/release/release PRE-CREATION
build-support/release/release-candidate PRE-CREATION
build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
docs/committers.md PRE-CREATION
docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
Diff: https://reviews.apache.org/r/19710/diff/
Testing
-------
Thanks,
Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/#review38793
-----------------------------------------------------------
build-support/release/release-candidate
<https://reviews.apache.org/r/19710/#comment71095>
This will create a .auroraversion set to 0.5.0 for 0.5.0-rc1, meaning there will exist at least 1 set of jars and sdists with their version metadata (pom.xml, EGG-INFO) set to "0.5.0" for each candidate even though they're really "0.5.0-rc1", "0.5.0-rc2", etc.
- Kevin Sweeney
On March 26, 2014, 8:24 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19710/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 8:24 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-78
> https://issues.apache.org/jira/browse/AURORA-78
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-78: automate and enforce release workflow
>
> Adds scripts to generate the CHANGELOG from JIRA, create the
> release candidate, generate the release candidate VOTE email draft,
> generate the release from the release candidate and the RESULT VOTE
> email draft. docs/committers.md added with process flow details.
>
>
> Diffs
> -----
>
> CHANGELOG PRE-CREATION
> build-support/release/changelog PRE-CREATION
> build-support/release/release PRE-CREATION
> build-support/release/release-candidate PRE-CREATION
> build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
> docs/committers.md PRE-CREATION
> docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
>
> Diff: https://reviews.apache.org/r/19710/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/#review41857
-----------------------------------------------------------
Ship it!
build-support/release/release-candidate
<https://reviews.apache.org/r/19710/#comment75494>
convert tabs to spaces
build-support/release/release-candidate
<https://reviews.apache.org/r/19710/#comment75495>
typo in warning
- Kevin Sweeney
On April 29, 2014, 8:32 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19710/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 8:32 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-78
> https://issues.apache.org/jira/browse/AURORA-78
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-78: automate and enforce release workflow
>
> Adds scripts to generate the CHANGELOG from JIRA, create the
> release candidate, generate the release candidate VOTE email draft,
> generate the release from the release candidate and the RESULT VOTE
> email draft. docs/committers.md added with process flow details.
>
>
> Diffs
> -----
>
> build-support/release/changelog PRE-CREATION
> build-support/release/release PRE-CREATION
> build-support/release/release-candidate PRE-CREATION
> build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
> docs/committers.md PRE-CREATION
> docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
>
> Diff: https://reviews.apache.org/r/19710/diff/
>
>
> Testing
> -------
>
> Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs.
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/#review41868
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On April 30, 2014, 11:38 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19710/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 11:38 a.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-78
> https://issues.apache.org/jira/browse/AURORA-78
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-78: automate and enforce release workflow
>
> Adds scripts to generate the CHANGELOG from JIRA, create the
> release candidate, generate the release candidate VOTE email draft,
> generate the release from the release candidate and the RESULT VOTE
> email draft. docs/committers.md added with process flow details.
>
>
> Diffs
> -----
>
> build-support/release/changelog PRE-CREATION
> build-support/release/release PRE-CREATION
> build-support/release/release-candidate PRE-CREATION
> build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
> build-support/release/verify-release-candidate PRE-CREATION
> docs/committers.md PRE-CREATION
> docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
>
> Diff: https://reviews.apache.org/r/19710/diff/
>
>
> Testing
> -------
>
> Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs.
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/
-----------------------------------------------------------
(Updated April 30, 2014, 6:38 p.m.)
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-78
https://issues.apache.org/jira/browse/AURORA-78
Repository: aurora
Description
-------
AURORA-78: automate and enforce release workflow
Adds scripts to generate the CHANGELOG from JIRA, create the
release candidate, generate the release candidate VOTE email draft,
generate the release from the release candidate and the RESULT VOTE
email draft. docs/committers.md added with process flow details.
Diffs (updated)
-----
build-support/release/changelog PRE-CREATION
build-support/release/release PRE-CREATION
build-support/release/release-candidate PRE-CREATION
build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
build-support/release/verify-release-candidate PRE-CREATION
docs/committers.md PRE-CREATION
docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
Diff: https://reviews.apache.org/r/19710/diff/
Testing
-------
Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs.
Thanks,
Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/
-----------------------------------------------------------
(Updated April 30, 2014, 6:09 p.m.)
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Changes
-------
Addresses comments for release-candidate script, adds verify-release-candidate script and adds update to release script to update .auroraversion and create a release branch along with the tag.
Bugs: AURORA-78
https://issues.apache.org/jira/browse/AURORA-78
Repository: aurora
Description
-------
AURORA-78: automate and enforce release workflow
Adds scripts to generate the CHANGELOG from JIRA, create the
release candidate, generate the release candidate VOTE email draft,
generate the release from the release candidate and the RESULT VOTE
email draft. docs/committers.md added with process flow details.
Diffs (updated)
-----
build-support/release/changelog PRE-CREATION
build-support/release/release PRE-CREATION
build-support/release/release-candidate PRE-CREATION
build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
build-support/release/verify-release-candidate PRE-CREATION
docs/committers.md PRE-CREATION
docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
Diff: https://reviews.apache.org/r/19710/diff/
Testing
-------
Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs.
Thanks,
Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/
-----------------------------------------------------------
(Updated April 30, 2014, 3:32 a.m.)
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Changes
-------
Tested release-candidate and changelog scripts and updated documentation. have not run the release script as I did not want to put source releases up that could get picked up by mirrors and distributed without a vote.
Bugs: AURORA-78
https://issues.apache.org/jira/browse/AURORA-78
Repository: aurora
Description
-------
AURORA-78: automate and enforce release workflow
Adds scripts to generate the CHANGELOG from JIRA, create the
release candidate, generate the release candidate VOTE email draft,
generate the release from the release candidate and the RESULT VOTE
email draft. docs/committers.md added with process flow details.
Diffs (updated)
-----
build-support/release/changelog PRE-CREATION
build-support/release/release PRE-CREATION
build-support/release/release-candidate PRE-CREATION
build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
docs/committers.md PRE-CREATION
docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
Diff: https://reviews.apache.org/r/19710/diff/
Testing
-------
Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs.
Thanks,
Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/
-----------------------------------------------------------
(Updated April 28, 2014, 4:12 a.m.)
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-78
https://issues.apache.org/jira/browse/AURORA-78
Repository: aurora
Description
-------
AURORA-78: automate and enforce release workflow
Adds scripts to generate the CHANGELOG from JIRA, create the
release candidate, generate the release candidate VOTE email draft,
generate the release from the release candidate and the RESULT VOTE
email draft. docs/committers.md added with process flow details.
Diffs
-----
build-support/release/changelog PRE-CREATION
build-support/release/release PRE-CREATION
build-support/release/release-candidate PRE-CREATION
build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
docs/committers.md PRE-CREATION
docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
Diff: https://reviews.apache.org/r/19710/diff/
Testing (updated)
-------
Have been running these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs.
Thanks,
Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/
-----------------------------------------------------------
(Updated April 28, 2014, 3:39 a.m.)
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Changes
-------
All comments addressed, switched to dry-run as the default and added more documentation
Bugs: AURORA-78
https://issues.apache.org/jira/browse/AURORA-78
Repository: aurora
Description
-------
AURORA-78: automate and enforce release workflow
Adds scripts to generate the CHANGELOG from JIRA, create the
release candidate, generate the release candidate VOTE email draft,
generate the release from the release candidate and the RESULT VOTE
email draft. docs/committers.md added with process flow details.
Diffs (updated)
-----
build-support/release/changelog PRE-CREATION
build-support/release/release PRE-CREATION
build-support/release/release-candidate PRE-CREATION
build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
docs/committers.md PRE-CREATION
docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
Diff: https://reviews.apache.org/r/19710/diff/
Testing
-------
Thanks,
Jake Farrell
Re: Review Request 19710: AURORA-78: automate and enforce release workflow
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19710/#review38758
-----------------------------------------------------------
build-support/release/changelog
<https://reviews.apache.org/r/19710/#comment71030>
Can you include a usage preamble, along with concise prose about what this does?
build-support/release/changelog
<https://reviews.apache.org/r/19710/#comment71037>
Please wrap at 100 cols.
Perhaps stating the obvious, but for others - we'll need to go back and tag fixVersion on tickets to make this first release changelog accurate.
build-support/release/release
<https://reviews.apache.org/r/19710/#comment71029>
consider adding:
set -o nounset
build-support/release/release
<https://reviews.apache.org/r/19710/#comment71040>
Mind using single quotes for strings you don't intend to interpolate?
build-support/release/release
<https://reviews.apache.org/r/19710/#comment71042>
I don't feel too strongly on this, but i've ~completely replaced my use of backticks with $(). Some reasoning matches this SO answer: http://stackoverflow.com/questions/9405478/command-substitution-backticks-or-dollar-sign-paren-enclosed
build-support/release/release-candidate
<https://reviews.apache.org/r/19710/#comment71031>
How would you feel about inverse behavior here - dry run by default? I'm not firm on this, but i tend to like it for scripts that you might be embarrassed by accidentally invoking.
docs/committers.md
<https://reviews.apache.org/r/19710/#comment71035>
Trim this to match the heading text.
docs/committers.md
<https://reviews.apache.org/r/19710/#comment71032>
trailing whitespace, here and below
docs/committers.md
<https://reviews.apache.org/r/19710/#comment71033>
Please wrap at 100 cols, here and below
- Bill Farner
On March 27, 2014, 3:24 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19710/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 3:24 a.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-78
> https://issues.apache.org/jira/browse/AURORA-78
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-78: automate and enforce release workflow
>
> Adds scripts to generate the CHANGELOG from JIRA, create the
> release candidate, generate the release candidate VOTE email draft,
> generate the release from the release candidate and the RESULT VOTE
> email draft. docs/committers.md added with process flow details.
>
>
> Diffs
> -----
>
> CHANGELOG PRE-CREATION
> build-support/release/changelog PRE-CREATION
> build-support/release/release PRE-CREATION
> build-support/release/release-candidate PRE-CREATION
> build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b
> docs/committers.md PRE-CREATION
> docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0
>
> Diff: https://reviews.apache.org/r/19710/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>