You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/05/30 13:06:29 UTC

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/
-----------------------------------------------------------

(Updated May 30, 2018, 9:06 p.m.)


Review request for mesos and Gilbert Song.


Summary (updated)
-----------------

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.


Bugs: MESOS-7691
    https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
-------

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67358/diff/2/

Changes: https://reviews.apache.org/r/67358/diff/1-2/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/#review204437
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On May 30, 2018, 6:10 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67358/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 6:10 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
>     https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67358/diff/2/
> 
> 
> Testing
> -------
> 
> Ran this test repeatedly
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/#review204497
-----------------------------------------------------------




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 1801 (patched)
<https://reviews.apache.org/r/67358/#comment286972>

    I think we dont need the _PERF_ if we do the change in previous patch


- Gilbert Song


On May 30, 2018, 6:10 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67358/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 6:10 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
>     https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67358/diff/2/
> 
> 
> Testing
> -------
> 
> Ran this test repeatedly
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/#review204981
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On June 13, 2018, 7:25 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67358/
> -----------------------------------------------------------
> 
> (Updated June 13, 2018, 7:25 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
>     https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 
> 
> 
> Diff: https://reviews.apache.org/r/67358/diff/3/
> 
> 
> Testing
> -------
> 
> Ran this test repeatedly
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/
-----------------------------------------------------------

(Updated June 13, 2018, 10:25 p.m.)


Review request for mesos and Gilbert Song.


Summary (updated)
-----------------

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.


Bugs: MESOS-7691
    https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
-------

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67358/diff/3/

Changes: https://reviews.apache.org/r/67358/diff/2-3/


Testing
-------

Ran this test repeatedly


Thanks,

Qian Zhang


Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/
-----------------------------------------------------------

(Updated May 30, 2018, 9:10 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
    https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
-------

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.


Diffs
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp 231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67358/diff/2/


Testing (updated)
-------

Ran this test repeatedly


Thanks,

Qian Zhang